-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: match exercise order to book chapters #541
Conversation
Hi, this pr need some local testing? If so I can checkout and test myself I use rustling with students and feel some problems due to mismatch with book chapters/rustlings order. |
Hello, I have tested this locally. But feel free to double check :) |
Hi @JuliaCao, this is a very good idea. While I have not pulled the changes locally yet, I don't see how this would not be better than the current ordering of the exercises. However, I have noticed that you've got a Thanks, |
e2b599b
to
b945c75
Compare
Hi Abdou, Thanks for getting back on this. I've just rebased and updated my branch. Please take a look and let me know what you think. Thanks, |
Added exercise to book chapter mapping table to exercise README
b945c75
to
a15a5d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JuliaCao thanks for making the change. @fmoko this should be good to go.
I'm not sure whether this would necessitate a breaking change? |
@fmoko none that I could detect. The way the Thanks, |
@AbdouSeck Yup, I think deciding whether it's a breaking change is mostly a semantic thing here, but I'll go with your judgement. Thanks! |
@JuliaCao @fmoko I really messed up here. The merged
This may have happened during Thanks, |
@AbdouSeck Sure. Let me take a look |
Opened a new PR for a fix here #598 |
@JuliaCao wonderful. I'll get on it ASAP. Thanks! |
Added exercise to book chapter mapping table to exercise README
Added exercise to book chapter mapping table to exercise README
Added exercise to book chapter mapping table to exercise README
Added exercise to book chapter mapping table to exercise README
Added exercise to book chapter mapping table to exercise README
Added exercise to book chapter mapping table to exercise README
Added exercise to book chapter mapping table to exercise README
Exercises are not organized in order for
rustlings watch
and it was hard to follow the exercises because we always had to jump back and forth between chapters.