chore: update variables5.rs book link #351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chore
Contributors |
saurav-2104
force-pushed
the
master
branch
2 times, most recently
from
5f7006d
to
a9a2e71
Compare
saurav-2104
changed the title
|
As a first time user, I was not able to figure out which book the exercise was talking about. |
jrvidal
reviewed
Apr 12, 2020
info.toml
Outdated
| @@ -52,7 +52,8 @@ because we want to assign a different typed value to an existing variable. Somet | |||
| you may also like to reuse existing variable names because you are just converting | |||
| values to different types like in this exercise. | |||
| Fortunately Rust has a powerful solution to this problem: 'Shadowing'! | |||
| You can read more about 'Shadowing' in the book's section 'Variables and Mutability'. | |||
| You can read more about 'Shadowing' in the book's section 'Variables and Mutability': | |||
| https://doc.rust-lang.org/book/ch03-01-variables-and-mutability.html?highlight=variables#shadowing. | |||
There was a problem hiding this comment.
Hm, do we want the highlight query param?
There was a problem hiding this comment.
Oh, my bad. I think I copied my searched results from browser. Removed it.
jrvidal
reviewed
Apr 12, 2020
info.toml
Outdated
| @@ -52,7 +52,8 @@ because we want to assign a different typed value to an existing variable. Somet | |||
| you may also like to reuse existing variable names because you are just converting | |||
| values to different types like in this exercise. | |||
| Fortunately Rust has a powerful solution to this problem: 'Shadowing'! | |||
| You can read more about 'Shadowing' in the book's section 'Variables and Mutability'. | |||
| You can read more about 'Shadowing' in the book's section 'Variables and Mutability': | |||
| https://doc.rust-lang.org/book/ch03-01-variables-and-mutability.html#shadowing. | |||
There was a problem hiding this comment.
One last minor nit: in my terminal, the final dot messes with the link, so it ends up not jumping to the "Shadowing" section.
There was a problem hiding this comment.
Removed "."
Also, cargo updated the Cargo.lock as well. At this point, I am not sure if it is unwanted.
chore: update variables5.rs book link chore: update variables5.rs book link
shadows-withal
approved these changes
Apr 12, 2020
alphamodel
pushed a commit
to wanglongqi/rustlings-solutions
that referenced
this pull request
Apr 27, 2020
chore: update variables5.rs book link chore: update variables5.rs book link
MendelMonteiro
pushed a commit
to MendelMonteiro/rustlings
that referenced
this pull request
Jun 28, 2020
chore: update variables5.rs book link chore: update variables5.rs book link
ppp3
pushed a commit
to ppp3/rustlings
that referenced
this pull request
May 23, 2022
chore: update variables5.rs book link chore: update variables5.rs book link
dmoore04
pushed a commit
to dmoore04/rustlings
that referenced
this pull request
Sep 11, 2022
chore: update variables5.rs book link chore: update variables5.rs book link
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore: update variables5.rs book link