Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(primitive_types4): Fail on a slice covering the wrong area #209

Merged
merged 1 commit into from
Aug 18, 2019

Commits on Aug 18, 2019

  1. fix(primitive_types4): Fail on a slice covering the wrong area

    This commit converts primitive_types4 to a test and asserts that the
    slice given is equal to the expected slice.
    
    The intent of the primitive_types4 exercise appears to be to ensure the
    user understands inclusive and exclusive bounds as well as slice syntax.
    `rustlings` commands using `compile` do not verify that a specific
    println is reached and, in the case of `watch` and `verify` (but not
    `run`), they do not output the `println`s at all.
    
    This fix is semantically similar to rust-lang#198. It does not take a stance on
    the correct way to handle this for all exercises; see rust-lang#127. There are
    likely other exercises whose intent are masked by this issue.
    dylnuge committed Aug 18, 2019
    Configuration menu
    Copy the full SHA
    5b1e673 View commit details
    Browse the repository at this point in the history