Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustlings run does not work with clippy exercises #291

Closed
jrvidal opened this issue Apr 7, 2020 · 1 comment
Closed

rustlings run does not work with clippy exercises #291

jrvidal opened this issue Apr 7, 2020 · 1 comment

Comments

@jrvidal
Copy link
Contributor

jrvidal commented Apr 7, 2020 

⠚ Compiling exercises/clippy/clippy1.rs...
thread 'main' panicked at 'Failed to run 'run' command: Os { code: 2, kind: NotFound, message: "No such file or directory" }', src/exercise.rs:134:19

The issue is in exercise::Exercise::compile, where we assume that the executable is in temp_file(), but the clippy compilation does not actually build there.
@crodjer
Copy link
Contributor

crodjer commented Apr 7, 2020

@jrvidal I'd like to take fixing this up. It'd be a learning experience for me.

alphamodel pushed a commit to wanglongqi/rustlings-solutions that referenced this issue Apr 27, 2020
@crodjer @wanglongqi
fix(run): compile clippy exercise files
6d5e621 
Additionally to running clippy, also compile the exercise file so that
`rustling run clippy1` works after a successful completion of the
exercise.

closes rust-lang#291

Signed-off-by: Rohan Jain <[email protected]>
MendelMonteiro pushed a commit to MendelMonteiro/rustlings that referenced this issue Jun 28, 2020
@crodjer @MendelMonteiro
fix(run): compile clippy exercise files
2dccc17 
Additionally to running clippy, also compile the exercise file so that
`rustling run clippy1` works after a successful completion of the
exercise.

closes rust-lang#291

Signed-off-by: Rohan Jain <[email protected]>
ppp3 pushed a commit to ppp3/rustlings that referenced this issue May 23, 2022
fix(run): compile clippy exercise files
b5d0d86 
Additionally to running clippy, also compile the exercise file so that
`rustling run clippy1` works after a successful completion of the
exercise.

closes rust-lang#291

Signed-off-by: Rohan Jain <[email protected]>
dmoore04 pushed a commit to dmoore04/rustlings that referenced this issue Sep 11, 2022
@crodjer @jrvidal
fix(run): compile clippy exercise files
68547f0 
Additionally to running clippy, also compile the exercise file so that
`rustling run clippy1` works after a successful completion of the
exercise.

closes rust-lang#291

Signed-off-by: Rohan Jain <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@crodjer @jrvidal