Skip to content

Commit

Permalink
fix: use trait objects for try_from_into
Browse files Browse the repository at this point in the history
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors.  In the tests, explicitly check `is_ok()` instead of trying to
force the error type to `String` (or other `PartialEq` type) using
`assert_eq!()`.
  • Loading branch information
tlyu committed Apr 4, 2021
1 parent 9aeca3f commit 2e93a58
Showing 1 changed file with 22 additions and 18 deletions.
40 changes: 22 additions & 18 deletions exercises/conversions/try_from_into.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
// instead of the target type itself.
// You can read more about it at https://doc.rust-lang.org/std/convert/trait.TryFrom.html
use std::convert::{TryFrom, TryInto};
use std::error;

#[derive(Debug, PartialEq)]
struct Color {
Expand All @@ -24,19 +25,19 @@ struct Color {

// Tuple implementation
impl TryFrom<(i16, i16, i16)> for Color {
type Error = String;
type Error = Box<dyn error::Error>;
fn try_from(tuple: (i16, i16, i16)) -> Result<Self, Self::Error> {}
}

// Array implementation
impl TryFrom<[i16; 3]> for Color {
type Error = String;
type Error = Box<dyn error::Error>;
fn try_from(arr: [i16; 3]) -> Result<Self, Self::Error> {}
}

// Slice implementation
impl TryFrom<&[i16]> for Color {
type Error = String;
type Error = Box<dyn error::Error>;
fn try_from(slice: &[i16]) -> Result<Self, Self::Error> {}
}

Expand Down Expand Up @@ -76,41 +77,43 @@ mod tests {
}
#[test]
fn test_tuple_correct() {
let c: Result<Color, String> = (183, 65, 14).try_into();
let c: Result<Color, _> = (183, 65, 14).try_into();
assert!(c.is_ok());
assert_eq!(
c,
Ok(Color {
c.unwrap(),
Color {
red: 183,
green: 65,
blue: 14
})
}
);
}
#[test]
fn test_array_out_of_range_positive() {
let c: Result<Color, String> = [1000, 10000, 256].try_into();
let c: Result<Color, _> = [1000, 10000, 256].try_into();
assert!(c.is_err());
}
#[test]
fn test_array_out_of_range_negative() {
let c: Result<Color, String> = [-10, -256, -1].try_into();
let c: Result<Color, _> = [-10, -256, -1].try_into();
assert!(c.is_err());
}
#[test]
fn test_array_sum() {
let c: Result<Color, String> = [-1, 255, 255].try_into();
let c: Result<Color, _> = [-1, 255, 255].try_into();
assert!(c.is_err());
}
#[test]
fn test_array_correct() {
let c: Result<Color, String> = [183, 65, 14].try_into();
let c: Result<Color, _> = [183, 65, 14].try_into();
assert!(c.is_ok());
assert_eq!(
c,
Ok(Color {
c.unwrap(),
Color {
red: 183,
green: 65,
blue: 14
})
}
);
}
#[test]
Expand All @@ -131,14 +134,15 @@ mod tests {
#[test]
fn test_slice_correct() {
let v = vec![183, 65, 14];
let c: Result<Color, String> = Color::try_from(&v[..]);
let c: Result<Color, _> = Color::try_from(&v[..]);
assert!(c.is_ok());
assert_eq!(
c,
Ok(Color {
c.unwrap(),
Color {
red: 183,
green: 65,
blue: 14
})
}
);
}
#[test]
Expand Down

1 comment on commit 2e93a58

@harshaallenki
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi,
I am a rust beginner and I am using Rustlings to get familiarized with the Rust. I am having trouble with understanding the expectations of the try_from_into exercise after this change.
Returning a String wrapped in Err

(Err(String::from("Failed to convert"))

does not seems to work as the String does not have the error::Error trait implemented, so are we expected to implement the error::Error trait for Color and return a wrapped Color instance in Err?
Apologies if there is a simpler and easy way than this.

Regards

Please sign in to comment.