Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: ICE with expanded code #6105 #6112

Merged
merged 5 commits into from
Mar 17, 2024
Merged

Conversation

Tanjaint21
Copy link
Contributor

@Tanjaint21 Tanjaint21 commented Mar 11, 2024

This is my first pull request 🎉
In this, I am fixing this issue as per suggested by @ytmimi
Thank You.

@ytmimi
Copy link
Contributor

ytmimi commented Mar 12, 2024

@Tanjaint21 thanks for helping out with this one. When you have a moment could you add the code snippet listed in #6105 (comment) as a test case.

It would also be great if you could add a test case for the code snippet in #5885 as I believe that we should no longer panic when reformatting that macro.

@Tanjaint21
Copy link
Contributor Author

Hi @ytmimi, I have added the test cases for both #5885 and #6105

@ytmimi
Copy link
Contributor

ytmimi commented Mar 16, 2024

Awesome! one last ask. When you get a second can you add these new files to this test. I've been adding test cases here to prevent any regressions.

@ytmimi ytmimi added release-notes Needs an associated changelog entry and removed pr-waiting-on-author labels Mar 17, 2024
@ytmimi
Copy link
Contributor

ytmimi commented Mar 17, 2024

Thanks again for your help on this one, and cheers on your first contribution to rustfmt 🎉

@ytmimi ytmimi merged commit 202fa22 into rust-lang:master Mar 17, 2024
27 checks passed
@ojeda
Copy link

ojeda commented Mar 17, 2024

Thanks for fixing those!

@ytmimi ytmimi removed the release-notes Needs an associated changelog entry label Jul 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustfmt ICE with expanded code ICE: unreachable src/tools/rustfmt/src/expr.rs:407:13
4 participants