Remove rustc-workspace-hack #5776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
force-pushed
the
remove-workspace-hack
branch
from
1903da4 to
7bd4464
Compare
|
Thank you for this. Are you fairly confident this removal won't cause any issues and/or have we tested in r-l/rust? Seems like it should be fine given the upstream context, just would hate to have this cause some breakage we don't discover till we're on the last leg of a subtree sync |
|
Yea, I am confident there shouldn't be any issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
rustc-workspace-hackdependency was removed in rust-lang/rust#109133 and should no longer be needed.