Don't remove non-breaking space in block comment with bare lines #5643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes 5638 Block comments with bare lines are those that have lines without leading `*` characters. When reformatting these comments we should be mindful not to remove leading non-breaking spaces (U+00A0).
|
iirc this is on the call path for both comments and macros. do you think there's any potential unintended side effects in the macro context, and if so, could we trigger the idempotence check between this branch and the mainline? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5638
Block comments with bare lines are those that have lines without leading
*characters. When reformatting these comments we should be mindful not to remove leading non-breaking spaces (U+00A0).