Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect string indentation in macro defs with format_strings #5201

Merged
merged 1 commit into from
Feb 11, 2022
Merged

Fix incorrect string indentation in macro defs with format_strings #5201

merged 1 commit into from
Feb 11, 2022

Conversation

yodaldevoid
Copy link
Contributor

Fixes #4036

ytmimi
ytmimi reviewed Jan 29, 2022
View reviewed changes
src/utils.rs Outdated Show resolved Hide resolved
@yodaldevoid yodaldevoid force-pushed the issue_4036-wrap_comments_format_strings_fix branch 2 times, most recently from 497548f to 1a9b956 Compare January 30, 2022 18:19
camelid
camelid reviewed Jan 31, 2022
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@yodaldevoid yodaldevoid force-pushed the issue_4036-wrap_comments_format_strings_fix branch 2 times, most recently from 10eb2c0 to 59ea71a Compare January 31, 2022 02:46
calebcartwright
calebcartwright reviewed Feb 7, 2022
View reviewed changes
Copy link
Member

@calebcartwright calebcartwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! Couple minor asks left inline below, otherwise good to go

CHANGELOG.md Outdated Show resolved Hide resolved
tests/target/issue-4036.rs Outdated Show resolved Hide resolved
@yodaldevoid yodaldevoid force-pushed the issue_4036-wrap_comments_format_strings_fix branch from 59ea71a to 893efcf Compare February 10, 2022 02:22
@calebcartwright
Copy link
Member

Awesome, thank you!

@calebcartwright calebcartwright merged commit ace7241 into rust-lang:master Feb 11, 2022
@yodaldevoid yodaldevoid mentioned this pull request May 23, 2022
Open
@ytmimi ytmimi mentioned this pull request Nov 20, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@camelid camelid camelid left review comments

@ytmimi ytmimi ytmimi left review comments

@calebcartwright calebcartwright calebcartwright left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bizarre string indentation with format_strings and wrap_comments
4 participants
@yodaldevoid @calebcartwright @ytmimi @camelid