maintain more AST info when formatting a RHS #5113
Merged
+86
−19
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently utilize generics, primarily bound on our
Rewrite
trait, when formatting a RHS (e.g. on an assignment) which makes perfect sense given the high number of expression variants, bounds, etc. that can be encountered. However, in doing so the functions that actually define the logic which handles orchestrating the rewriting of the RHS and then combining it with the LHS are missing various data points from the respective AST nodes.That's not been a problem historically, however, we have a few outstanding requests for more optionality around formatting of chains including formatting results which knowingly exceed the
max_width
boundary. In order to support these use cases while still being able to block indent the start of the RHS some additional AST metadata will be needed, and that metadata is accordingly incorporated and passed along with the changes in this PR.Refs #3863 #4306