Stabilize blank_lines_upper_bound

[faern]

Closes #3381

Looks like any outstanding discussion has died out and that we won't change the default? Can we stabilize this feature please? If anything, the discussion around the default showed that many people want this set to two or higher. So let us do that on stable rather than needing to use the nightly formatter in our CI just to check formatting.

I have not contributed to rustfmt before. Maybe I'm not doing the correct thing here. I just mimicked other stabilization PRs. I want to get this ball rolling.

The formatting RFC discussion: rust-lang/style-team#57

[calebcartwright]

Thank you for the PR and your interest in contributing to rustfmt! Unfortunately, I am going to close this as stabilization is not viable at this time (#3381 (comment))

Looks like any outstanding discussion has died out and that we won't change the default?
If anything, the discussion around the default showed that many people want this set to two or higher. So let us do that on stable rather than needing to use the nightly formatter in our CI just to check formatting

I appreciate your frustration, but will refer you to my comment linked above. The default value is not going to change.

Can we stabilize this feature please?
I have not contributed to rustfmt before. Maybe I'm not doing the correct thing here. I just mimicked other stabilization PRs. I want to get this ball rolling

Will again refer to the linked comment for the longer response. We cannot stabilize the option because there's more to do beyond just flipping the flag to make it stable.

Thanks again though!

[faern]

Ok. Sorry to hear that. Yeah I know the default was not going to change. That's why I thought it could be stabilized. I did not find any concrete list of todo items such as missing tests or anything. It would be helpful if the initial post of the tracking issue had a list of outstanding issues with checkmarks.

Sorry that I missed the documentation section about stabilizing options. I only skimmed Contributing.md and did not realize there were other documents on contributing. I fully agree premature stabilization is evil, so I understand. I was just not able to find the list of remaining problems for this option.

[calebcartwright]

No worries!

It would be helpful if the initial post of the tracking issue had a list of outstanding issues with checkmarks.

I've been thinking about going through all the open ones and at least plugging in the link or adding a comment with a link to the stabilization requirements, but am extremely resource constrained with too many higher priority items to do even that; much less enumerate the specific outstanding items for each issue.

Unfortunately I don't think it'd be feasible to do anything beyond enumerating/linking to the requirements at issue creation either, as most of the stabilization-blocking issues aren't known straight away