fix TrailingWhitespace when using line breaks in macros arguments #3768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchaser53
commented
Sep 1, 2019
| @@ -41,6 +42,7 @@ pub(crate) struct RewriteContext<'a> { | |||
| pub(crate) macro_rewrite_failure: RefCell<bool>, | |||
| pub(crate) report: FormatReport, | |||
| pub(crate) skip_context: SkipContext, | |||
| pub(crate) skipped_range: Rc<RefCell<Vec<(usize, usize)>>>, | |||
There was a problem hiding this comment.
This is an important point in this PR. I want to use skipped_range in RewriteContext. It's used to resolve #3717. I think the skipped_range should include the failed format span or skipped span.
This is also related with #3761. The case #3761 is a case the edge of the span has white space. It's easy to resolve. Just trim the white space. But I think no way to avoid TrailingWhitespace error now in a case the failed format span has newline now.
// case like #3761. just trim the white space.
let snippet = " let a = 1;";
// case like this PR. no way to avoid TrailingWhitespace error now
a_macro!(name<Param1, Param2>,
);
topecongiro
suggested changes
Sep 2, 2019
This was referenced Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2916