Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the comment for self are swallowed #3415

Merged
merged 2 commits into from
Mar 4, 2019
Merged

fix the comment for self are swallowed #3415

merged 2 commits into from
Mar 4, 2019

Conversation

rchaser53
Copy link
Contributor

related: #3198

This is a bug fix, so I don't need to add Version Gate. Did I get that right?

@rchaser53 rchaser53 changed the title fix the comment for self are swallowed [WIP]fix the comment for self are swallowed Feb 25, 2019
topecongiro
topecongiro reviewed Feb 25, 2019
View reviewed changes
Copy link
Contributor

@topecongiro topecongiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

src/items.rs Outdated Show resolved Hide resolved
topecongiro
topecongiro reviewed Feb 25, 2019
View reviewed changes
src/items.rs Outdated Show resolved Hide resolved
@rchaser53
Copy link
Contributor Author

Thank you for the review. I fixed it.

@rchaser53 rchaser53 changed the title [WIP]fix the comment for self are swallowed fix the comment for self are swallowed Feb 25, 2019
scampi
scampi reviewed Feb 26, 2019
View reviewed changes
src/items.rs Outdated Show resolved Hide resolved
@rchaser53 rchaser53 changed the title fix the comment for self are swallowed [wip] fix the comment for self are swallowed Feb 27, 2019
@rchaser53
Copy link
Contributor Author

I think I should fix other place, so add wip to title.

@rchaser53 rchaser53 changed the title [wip] fix the comment for self are swallowed fix the comment for self are swallowed Feb 27, 2019
@rchaser53
Copy link
Contributor Author

I improved the implements

scampi
scampi suggested changes Mar 2, 2019
View reviewed changes
src/items.rs Show resolved Hide resolved
src/items.rs Show resolved Hide resolved
@rchaser53
Copy link
Contributor Author

Thank you fot the review.
I added the comment and some tests.

@scampi
Copy link
Contributor

scampi commented Mar 4, 2019

Looking good! @topecongiro are you OK with the changes ?

@scampi
Copy link
Contributor

scampi commented Mar 4, 2019

build failure is unrelated, it's about clippy failing to compile (before running rustfmt).

@topecongiro
Copy link
Contributor

LGTM, thanks!

@topecongiro topecongiro merged commit 51af195 into rust-lang:master Mar 4, 2019
@rchaser53 rchaser53 deleted the issue-3198 branch March 4, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@topecongiro topecongiro topecongiro left review comments

@scampi scampi scampi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rchaser53 @scampi @topecongiro