Skip to content

cargo-fmt: remove command line validation which did not properly handle the windows environment #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
scampi wants to merge 3 commits into from
Closed

cargo-fmt: remove command line validation which did not properly handle the windows environment #3309

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2a76d95
cargo-fmt: skip only the executable name
scampi Feb 1, 2019
06d8feb
canonicalize on Windows returns an extended-length path which adds a …
scampi Feb 2, 2019
ec8ec05
cargo-fmt: skip the first two args which are the bin's name and fmt, …
scampi Feb 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/cargo-fmt/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -242,7 +242,9 @@ fn get_targets_root_only(targets: &mut HashSet<Target>) -> Result<(), io::Error>
let in_workspace_root = workspace_root_path == current_dir;

for package in metadata.packages {
if in_workspace_root || PathBuf::from(&package.manifest_path) == current_dir_manifest {
if in_workspace_root
|| PathBuf::from(&package.manifest_path).canonicalize()? == current_dir_manifest
{
for target in package.targets {
targets.insert(Target::from_target(&target));
}
Expand Down