Unicode text wrapping in comments and string literals. #3275
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes several fixes related to #3235 .
Clearing the terminology: Replaced some identifier's "chars" into "width".
Introduce unicode_width crate, which implements UAX#11: Replaced some of the
str::len()
calls into this unicode width method calls to support characters occupying != 1 width (e.g. CJK, combined chars).Introduce unicode_categories crate just to make
is_punctuation()
method unicode supported: Without this CJK strings almost cannot be wrapped because it does not include whitespaces, and the oldis_punctuation()
method was only supporting ASCII delimiters.But by this fix we may over-detect the punctuation characters. For example, do we really want to insert newline after like "§" or "¶"? I'm not sure.
I believe the next step is to support UAX#14, which is defining the line-breaking algorithm. Then we can completely solve this punctuation issue.