Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generic_const_items syntax gets deleted #5995

Closed
lukas-code opened this issue Dec 28, 2023 · 3 comments · May be fixed by #5996
Closed

generic_const_items syntax gets deleted #5995

lukas-code opened this issue Dec 28, 2023 · 3 comments · May be fixed by #5996

Comments

@lukas-code
Copy link
Member

#![feature(generic_const_items)]
const C<T>: Option<T> = None;

becomes

#![feature(generic_const_items)]
const C: Option<T> = None;

playground

@ytmimi
Copy link
Contributor

ytmimi commented Dec 29, 2023

@lukas-code thanks for the report. I made a note of it on the tracking issue rust-lang/rust#113521

@fmease
Copy link
Member

fmease commented Nov 3, 2024

Should we close this issue now that rust-lang/rust#132540 has been merged?
Of course, that change hasn't been synced yet with this repo but I think that's acceptable.

The aforementioned PR doesn't implement proper formatting for GCIs but it prevents rustfmt from deleting syntax.
Codifying the style of GCIs (T-style, style guide) and impl'ing formatting (T-rustfmt) are already tracked in rust-lang/rust#113521.

@calebcartwright
Copy link
Member

yeah sounds reasonable, thanks for the follow up

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants