Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bytecount/simd-accel only works on x86, x86_64, aarch64, and arm+neon #3216

Closed
cuviper opened this issue Nov 26, 2018 · 0 comments
Closed

bytecount/simd-accel only works on x86, x86_64, aarch64, and arm+neon #3216

cuviper opened this issue Nov 26, 2018 · 0 comments
Labels
bug Panic, non-idempotency, invalid code, etc.
Milestone

Comments

@cuviper
Copy link
Member

cuviper commented Nov 26, 2018

bytecount = { version = "0.3", features = ["simd-accel"] }

This was added in #3096, but bytecount/simd-accel -> simd only works on x86, x86_64, aarch64, and arm with neon. As a result, all other architectures are missing rustfmt and rls in the current rust beta.

I believe in 0.4, bytecount/generic-simd should work everywhere, per llogiq/bytecount#44.

@topecongiro topecongiro added the bug Panic, non-idempotency, invalid code, etc. label Nov 27, 2018
@topecongiro topecongiro added this to the 1.0.1 milestone Nov 27, 2018
topecongiro added a commit to topecongiro/rustfmt that referenced this issue Nov 27, 2018
Update bytecount to 0.4, and use its generic feature.

Closes rust-lang#3216.
@nrc nrc closed this as completed in #3220 Nov 28, 2018
alexcrichton pushed a commit that referenced this issue Nov 29, 2018
Update bytecount to 0.4, and use its generic feature.

Closes #3216.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Panic, non-idempotency, invalid code, etc.
Projects
None yet
Development

No branches or pull requests

2 participants