Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle .. in tuple / tuple struct patterns (RFC 1492) #1021

Closed
kamalmarhubi opened this issue May 30, 2016 · 1 comment
Closed

Handle .. in tuple / tuple struct patterns (RFC 1492) #1021

kamalmarhubi opened this issue May 30, 2016 · 1 comment
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors

Comments

@kamalmarhubi
Copy link
Contributor

This was added in rust-lang/rust#33639 as implementation for RFC 1492. Support was added in syntex_syntax v0.33.
kamalmarhubi added a commit to kamalmarhubi/rustfmt that referenced this issue May 30, 2016
@kamalmarhubi
deps: Update syntex_syntax to 0.33
120e1a0 
This bump brings syntex_syntax support for `..` in tuple and tuple
struct patterns, which come from RFC 1492:
  https://github.com/rust-lang/rfcs/blob/master/text/1492-dotdot-in-patterns.md

These new patterns are not properly handled in this PR; instead rust-lang#1021
tracks supporting them.

Refs rust-lang#1021
@kamalmarhubi kamalmarhubi mentioned this issue May 30, 2016
Merged
@nrc nrc added the good first issue Issues up for grabs, also good candidates for new rustfmt contributors label May 31, 2016
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Handle .. in tuple struct pattern (rust-lang#1021)
5615c33
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
669f158
@sinkuu sinkuu mentioned this issue Sep 6, 2016
Closed
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
584c71f
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
8a30e54
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
ac4d9ba
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
dd7641f
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
5d256cd
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
8cfc5ed
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
5bcaaf6
@sinkuu
Copy link
Contributor

sinkuu commented Sep 6, 2016

Sorry for cluttering!
Fix: #1151

sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 6, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
2da1e1e
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 7, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
279f475
sinkuu added a commit to sinkuu/rustfmt that referenced this issue Sep 7, 2016
@sinkuu
Fix rust-lang#1021: Handle .. in tuple / tuple struct patterns
8436ecc
@nrc nrc closed this as completed in bf07856 Sep 13, 2016
nrc added a commit that referenced this issue Sep 13, 2016
@nrc
Merge pull request #1151 from sinkuu/issue1021
f9712b0 
Fix #1021: Handle `..` in tuple / tuple struct patterns
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Issues up for grabs, also good candidates for new rustfmt contributors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kamalmarhubi @nrc @sinkuu