Add support for raw-dylib #1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dpaoliello
force-pushed
the
rawdylib
branch
2 times, most recently
from
92d6d33
to
c38e2a5
Compare
|
I've updated rustc on the master branch. Would you mind rebasing this PR? |
Done |
|
Thanks a lot for all the work implementing this! |
This was referenced Aug 8, 2024
bjorn3
reviewed
Aug 9, 2024
|
rust-lang/rust#128896 will update the cg_clif shipped with rustup. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for generating MSVC compatible import libraries for the
raw-dylibfeature and removes the patches for the standard library that worked around the lack of support.Also, kudos to @simonbuchan who created an earlier prototype of
raw-dylibsupport as I used that as a guide for parts of this implementation.