Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wf-projection-stress-65510 benchmark. #566

Merged
merged 1 commit into from
Nov 26, 2019

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented Nov 26, 2019

This is a tweaked version of the stress test from rust-lang/rust#65510.

The version in this PR should take about a couple seconds in cargo check (I was getting 2.24s locally, using nightly) before any fix to rust-lang/rust#65510 is attempted, and prevent regressions once a fix does land (as well as letting us measure a fix in the first place).

@Mark-Simulacrum Mark-Simulacrum merged commit 0d38030 into rust-lang:master Nov 26, 2019
@eddyb eddyb deleted the wf-projection-stress-65510 branch November 26, 2019 20:13
@nnethercote
Copy link
Contributor

Thanks for updating the README file!

My only complaint is that the benchmark name is very long: 5 characters longer than unicode_normalization, which is currently the longest name. How about wf-projection-stress or wf-stress-65510?

@eddyb
Copy link
Member Author

eddyb commented Nov 27, 2019

Oh, whoops, didn't consider that (I assume it's relevant to the UI?).
At the very least, projection could be assoc or proj easily.

@Mark-Simulacrum Can the little data already collected be renamed to avoid the longer name showing up anywhere at all?

@nnethercote
Copy link
Contributor

We already have issue-46449 and regression-31157 benchmarks, too, so those are patterns that could be followed.

@Mark-Simulacrum
Copy link
Member

Yes, whatever data we have can be renamed; it's a bit of work but not too bad. I'd appreciate a PR doing the rename itself though (moving the directories over and such), I can do the legwork of renaming older data myself right as I merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants