Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

detailed (comparison) view: The cache misses column should be removed, invocations should be renamed #529

Closed
michaelwoerister opened this issue Oct 28, 2019 · 0 comments · Fixed by #573

Comments

@michaelwoerister
Copy link
Member

Since we don't record cache misses for perf.rlo, it does not make sense to show the number of cache misses (it will always be the same as the "# of invocations" right next to it).

When recording cache misses and cache hits, then invocations is hits + misses. When not recording cache hits, then invocations is misleading because it only counts the cache misses.

On zulip we settled on "full executions" as the new title for the "invocations" column. This subsumes "query provider invocations" and regular (thus uncached) function invocations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant