Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update HIR chapter to reflect the removal of NodeIds #759

Closed
wants to merge 3 commits into from

Conversation

LeSeulArtichaut
Copy link
Contributor

See rust-lang/rust#50928.

cc @marmeladema @zackmdavis can you confirm that everything is correct? I haven't really followed the HirId-ification initiative, and I just wrote what I could find in the docs and what I could guess.

@marmeladema
Copy link

marmeladema commented Jun 21, 2020

Documentation seems correct to me. One note though, NodeId are not entirely removed, they remain available / accessible before HIR lowering because that's how each AST nodes are identified. Most notably, they are heavily relied upon during name resolution passes.

EDIT: i don't know where and probably not in hir.md but i guess NodeId should still remain documented somewhere.

@mark-i-m
Copy link
Member

@LeSeulArtichaut Would you be willing to add a new chapter about identifiers throughout the compiler and move generic info there (and maybe also stuff like #748)?

@LeSeulArtichaut
Copy link
Contributor Author

Sure, will take a look :)

@mark-i-m
Copy link
Member

mark-i-m commented Aug 2, 2020

Friendly ping @LeSeulArtichaut

@jyn514 jyn514 added the waiting-on-author This PR is waiting for additional action by the OP label Sep 8, 2020
@LeSeulArtichaut
Copy link
Contributor Author

Closing in favor of #872

@tshepang tshepang deleted the LeSeulArtichaut-patch-1 branch September 11, 2020 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting-on-author This PR is waiting for additional action by the OP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants