Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rustdoc: Remove note about deprecated pass configuration #325

Closed
wants to merge 1 commit into from
Closed

rustdoc: Remove note about deprecated pass configuration #325

wants to merge 1 commit into from

Conversation

phansch
Copy link
Member

@phansch phansch commented May 30, 2019

It looks like this note refers to rust-lang/rust#50669
and rust-lang/rust#44136 which leads me to believe
that it can be safely removed.

cc @QuietMisdreavus

@QuietMisdreavus
Copy link
Member

The --passes flag still exists, though. It's still possible to pass something like --no-defaults --passes collect-trait-impls or something like that, but rustdoc will emit a deprecation warning for it. I feel like the note could still be kept, just reworded.

@mark-i-m mark-i-m added the S-waiting-on-author Status: this PR is waiting for additional action by the OP label Jun 3, 2019
@mark-i-m
Copy link
Member

@phansch Ping :)

@phansch
Copy link
Member Author

phansch commented Jun 11, 2019 •
edited
Loading

Thanks for the ping, I'm going to have to close this PR as I currently don't have enough time to work on it

@phansch phansch closed this Jun 11, 2019
@mark-i-m
Copy link
Member

Ok, thanks for the update...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
S-waiting-on-author Status: this PR is waiting for additional action by the OP
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phansch @QuietMisdreavus @mark-i-m