Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update query chapter for the query macro rewrite #296

Merged
merged 1 commit into from
Apr 16, 2019

Conversation

rasendubi
Copy link
Contributor

There was a big macro rewrite in these pull requests:
rust-lang/rust#56462
rust-lang/rust#59517

Update the query chapter to describe the new macro usage.

@Zoxc it would be nice if you could review this.

There was a big macro rewrite in these pull requests:
rust-lang/rust#56462
rust-lang/rust#59517

Update the query chapter to describe the new macro usage.
@rasendubi
Copy link
Contributor Author

CI failure does not seem to be relevant:

There were 17 broken links:
traits/lowering-rules.md#31: "https://github.com/rust-lang-nursery/chalk/blob/master/src/rules.rs" returned 404 Not Found
traits/wf.md#14: "https://github.com/rust-lang-nursery/chalk/blob/master/src/rules/wf.rs" returned 404 Not Found
traits/wf.md#16: "https://github.com/rust-lang-nursery/chalk/blob/master/src/rules/wf/test.rs" returned 404 Not Found
traits/chalk-overview.md#84: "https://github.com/rust-lang/chalk/blob/master/src/rust_ir.rs" returned 404 Not Found
traits/chalk-overview.md#146: "https://github.com/rust-lang/chalk/blob/master/src/coherence.rs" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#38: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#41: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#59: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#70: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#72: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#80: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#89: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#98: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#101: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#115: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
borrow_check/moves_and_initialization/move_paths.md#117: "https://doc.rust-lang.org/nightly/nightly-rustc/rustc_mir/dataflow/move_paths/indexes/struct.MovePathIndex.html" returned 404 Not Found
appendix/background.md#79: There was an error while fetching "https://cs.au.dk/~amoeller/spa/", https://cs.au.dk/~amoeller/spa/: timed out
2019-04-15 22:08:28 [ERROR] (mdbook::renderer): Renderer exited with non-zero return code.
2019-04-15 22:08:28 [ERROR] (mdbook::utils): Error: Rendering failed
2019-04-15 22:08:28 [ERROR] (mdbook::utils): 	Caused By: The "linkcheck" renderer failed
The command "mdbook build" exited with 101.

@mark-i-m
Copy link
Member

Thanks @rasendubi! I will take a look soon. It would also be great if @Zoxc could take a look, though, as I am not familiar with the changes.

@Zoxc
Copy link
Contributor

Zoxc commented Apr 16, 2019

The changes look good to me.

Copy link
Member

@mark-i-m mark-i-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mark-i-m mark-i-m merged commit 7503057 into rust-lang:master Apr 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants