Expand upon PR guidelines #1851
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noratrieb
approved these changes
Jan 14, 2024
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jan 16, 2024
Update books ## rust-lang/nomicon 1 commits in f6bd083c4ccfc4ce6699b8b4154e3c45c5a27a8c..6bc2415218d4dd0cb01433d8320f5ccf79c343a1 2024-01-03 04:01:04 UTC to 2024-01-03 04:01:04 UTC - Update an example of `thread_local` to use `local_key_cell_methods` (rust-lang/nomicon#438) ## rust-lang/reference 1 commits in 3565c7978cfc9662f5963b135690ff9cbbfa0318..8c77e8be9da1a9c70545556218d563c8d061f1fd 2024-01-08 15:16:51 UTC to 2024-01-08 15:16:51 UTC - Document that <- is a single token (rust-lang/reference#1424) ## rust-lang/rust-by-example 4 commits in c0be6299e52e4164c30ba6f41bd0ad0aaee64972..ddf5cb0e6ee54ba2dd84c8ca3e1314120014e20d 2024-01-13 11:06:22 UTC to 2024-01-13 11:01:00 UTC - Update attribute.md, (rust-lang/rust-by-example#1791) - fix: typo `unusude` (rust-lang/rust-by-example#1797) - Update print.md (rust-lang/rust-by-example#1796) - Update alias.md (rust-lang/rust-by-example#1790) ## rust-lang/rustc-dev-guide 4 commits in d13e85152a977cd0bcaf583cf5f49e86225697de..4af29d1a7f64f88a36539662c6a84fe1fbe6cde1 2024-01-14 10:42:53 UTC to 2024-01-06 17:47:01 UTC - Expand upon PR guidelines (rust-lang/rustc-dev-guide#1851) - Correct the link to rust reference (rust-lang/rustc-dev-guide#1848) - Explain the important concepts of exhaustiveness checking (rust-lang/rustc-dev-guide#1830) - Add guide for rustdoc search implementation (rust-lang/rustc-dev-guide#1846)
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 16, 2024
Rollup merge of rust-lang#119998 - rustbot:docs-update, r=ehuss Update books ## rust-lang/nomicon 1 commits in f6bd083c4ccfc4ce6699b8b4154e3c45c5a27a8c..6bc2415218d4dd0cb01433d8320f5ccf79c343a1 2024-01-03 04:01:04 UTC to 2024-01-03 04:01:04 UTC - Update an example of `thread_local` to use `local_key_cell_methods` (rust-lang/nomicon#438) ## rust-lang/reference 1 commits in 3565c7978cfc9662f5963b135690ff9cbbfa0318..8c77e8be9da1a9c70545556218d563c8d061f1fd 2024-01-08 15:16:51 UTC to 2024-01-08 15:16:51 UTC - Document that <- is a single token (rust-lang/reference#1424) ## rust-lang/rust-by-example 4 commits in c0be6299e52e4164c30ba6f41bd0ad0aaee64972..ddf5cb0e6ee54ba2dd84c8ca3e1314120014e20d 2024-01-13 11:06:22 UTC to 2024-01-13 11:01:00 UTC - Update attribute.md, (rust-lang/rust-by-example#1791) - fix: typo `unusude` (rust-lang/rust-by-example#1797) - Update print.md (rust-lang/rust-by-example#1796) - Update alias.md (rust-lang/rust-by-example#1790) ## rust-lang/rustc-dev-guide 4 commits in d13e85152a977cd0bcaf583cf5f49e86225697de..4af29d1a7f64f88a36539662c6a84fe1fbe6cde1 2024-01-14 10:42:53 UTC to 2024-01-06 17:47:01 UTC - Expand upon PR guidelines (rust-lang/rustc-dev-guide#1851) - Correct the link to rust reference (rust-lang/rustc-dev-guide#1848) - Explain the important concepts of exhaustiveness checking (rust-lang/rustc-dev-guide#1830) - Add guide for rustdoc search implementation (rust-lang/rustc-dev-guide#1846)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mention label has-merge-commits
At some point we added the label has-merge-commits which gets automatically added if a PR has merge commits. In rust-lang/rust#119938, @Nilstrieb has made it possible for unauthorized users to remove it via
@rustbotwhich makes perfect sense since it doesn't get removed automatically.I've added a paragraph for this since we didn't mention this label at all.
Add guidelines for backport-accepted PRs
This one codifies another case of “tribal knowledge”: Basically, one shouldn't use
Fixes #NNNin {beta,stable}-accepted PRs that fix stable-to-{beta,stable} regressions. I don't think I need to further justify this but just in case I do, cc this age-old comment rust-lang/rust#52873 (comment) and this recent PR rust-lang/rust#119477.