Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorganize and expand the testing chapters. #1281

Merged
merged 3 commits into from
Jan 18, 2022
Merged

Reorganize and expand the testing chapters. #1281

merged 3 commits into from
Jan 18, 2022

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Dec 27, 2021

This is an attempt to reorganize the layout of the testing chapters into something that makes a little more sense to me (though probably not everyone).
The new chapter layout is:

  • Testing the compiler — Introduction and high-level overview of different kinds of tests.
    • Running tests — How to run tests.
      • Testing with Docker — How to run tests with Docker.
      • Testing with CI — How to run tests with GitHub Actions.
    • Adding new tests — A basic overview and tutorial of adding a test.
    • Compiletest — Reference on how compiletest works and the different test suites.
      • UI tests — Reference on writing UI tests.
      • Test headers — Reference on test headers.
    • Performance testing — Intro to rustc-perf testing.
    • Crater — Overview of crater testing.

This also includes a lot of new content to fill out these sections.

@ehuss
Copy link
Contributor Author

ehuss commented Dec 27, 2021

cc @petrochenkov who mentioned they may be willing to look this over.

@petrochenkov petrochenkov self-assigned this Dec 28, 2021
@petrochenkov petrochenkov added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Dec 28, 2021
petrochenkov
petrochenkov reviewed Dec 29, 2021
View reviewed changes
src/tests/intro.md Outdated Show resolved Hide resolved
src/tests/ui.md Outdated Show resolved Hide resolved
src/tests/ui.md Outdated Show resolved Hide resolved
src/tests/ui.md Outdated Show resolved Hide resolved
src/tests/ui.md Outdated Show resolved Hide resolved
@petrochenkov petrochenkov removed the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Dec 29, 2021
@ehuss
Copy link
Contributor Author

ehuss commented Dec 29, 2021

Thanks for taking a look! I have applied some fixes.

@camelid
Copy link
Member

camelid commented Dec 30, 2021

@ehuss could you mark the accepted fixes as resolved to make it easier to follow along with what's been changed? Thanks!

@camelid camelid added the S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content label Dec 30, 2021
@spastorino
Copy link
Member

spastorino commented Jan 18, 2022 •
edited
Loading

This is great, there are some conflicts now after we've merged a couple of PRs. @ehuss can you rebase?.

@ehuss
Copy link
Contributor Author

ehuss commented Jan 18, 2022

Thanks, I have rebased.

@spastorino spastorino merged commit 78dd6a4 into rust-lang:master Jan 18, 2022
@ehuss ehuss mentioned this pull request Jan 19, 2022
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 19, 2022
@matthiaskrgr
Rollup merge of rust-lang#93062 - ehuss:update-books, r=ehuss
ea1275a 
Update books

## nomicon

1 commits in c05c452b36358821bf4122f9c418674edd1d713d..66d097d3d80e8f88c288c6879c7c2b909ecf8ad4
2021-12-13 15:23:48 +0900 to 2022-01-05 05:45:21 +0900
- Fix typo / type error in FFI code example (rust-lang/nomicon#327)

## reference

8 commits in f8ba2f12df60ee19b96de24ae5b73af3de8a446b..4dee6eb63d728ffb9e7a2ed443e9ada9275c69d2
2022-01-03 11:02:08 -0800 to 2022-01-18 09:26:33 -0800
- (minor) Remove Expression Path sub-types splits in Pattern specs (rust-lang/reference#1138)
- Document destructuring assignment (rust-lang/reference#1116)
- Document the 2021 edition changes to macros-by-example `pat` metavariables (rust-lang/reference#1135)
- Improve the documentation of macros-by-example metavariable names (rust-lang/reference#1130)
- trait-bounds.md: add pronoun 'that' (rust-lang/reference#1131)
- Say that macros-by-example `ident` metavariables can match raw identifiers (rust-lang/reference#1133)
- State in the UAX31 profile description that a lone `_` is not an identifier (rust-lang/reference#1129)
- Document syntax reserved in Rust 2021 (rust-lang/reference#1128)

## book

17 commits in d3740fb7aad0ea4a80ae20f64dee3a8cfc0c5c3c..f17df27fc14696912c48b8b7a7a8fa49e648088d
2022-01-03 21:46:04 -0500 to 2022-01-18 17:46:28 -0500
- Add a notice to the top of all nostarch snapshots
- Fix quotes
- Grammar (minor): 'or' → 'and' for enum variants
- Propagate edits of chapter 8 to src
- Replies to nostarch edits
- more edits
- ch8 from nostarch
- Fix grammar and line wrapping
- Merge remote-tracking branch 'origin/pr/2880'
- Remove wikipedia link
- Merge remote-tracking branch 'origin/pr/2927'
- Snapshot of ch14 for nostarch
- Backport fixes to chapter 14 noticed while doing nostarch snapshot
- Fix usage of find piped into xargs
- Adjust some more line numbers of Cargo.toml includes
- Merge branch '2909'
- Merge remote-tracking branch 'parkerziegler/fix/ch14-add-one-naming'

## rustc-dev-guide

7 commits in 875464457c4104686faf667f47848aa7b0f0a744..78dd6a4684cf8d6b72275fab6d0429ea40b66338
2021-12-28 22:17:49 -0600 to 2022-01-18 14:44:26 -0300
- Reorganize and expand the testing chapters. (rust-lang/rustc-dev-guide#1281)
- Add inline assembly internals (rust-lang/rustc-dev-guide#1266)
- Spelling: Rename `rust` to `Rust` (rust-lang/rustc-dev-guide#1288)
- Clean up section about FCPs (rust-lang/rustc-dev-guide#1287)
- Address more review comments in rust-lang/rustc-dev-guide#1286.
- Address review comments in rust-lang/rustc-dev-guide#1286.
- Streamline "Getting Started" some more.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@spastorino spastorino spastorino approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: this PR is waiting for a reviewer to verify its content
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehuss @camelid @spastorino @petrochenkov