Skip to content

Commit

Permalink
Fix trivial typo of "query-fied"
Browse files Browse the repository at this point in the history
"Query-field" should be "Query-fied" - three instances.
  • Loading branch information
cbloodsworth authored and tshepang committed Dec 18, 2024
1 parent 1bf21e3 commit 6604b46
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions src/overview.md
Original file line number Diff line number Diff line change
Expand Up @@ -284,7 +284,7 @@ queries are cached on disk so that the compiler can tell which queries' results
changed from the last compilation and only redo those. This is how incremental
compilation works.

In principle, for the query-field steps, we do each of the above for each item
In principle, for the query-fied steps, we do each of the above for each item
individually. For example, we will take the `HIR` for a function and use queries
to ask for the `LLVM-IR` for that HIR. This drives the generation of optimized
`MIR`, which drives the borrow checker, which drives the generation of `MIR`, and
Expand All @@ -303,11 +303,11 @@ to remain to ensure that unreachable functions still have their errors emitted.
[passes]: https://github.com/rust-lang/rust/blob/e69c7306e2be08939d95f14229e3f96566fb206c/compiler/rustc_interface/src/passes.rs#L791

Moreover, the compiler wasn't originally built to use a query system; the query
system has been retrofitted into the compiler, so parts of it are not query-field
system has been retrofitted into the compiler, so parts of it are not query-fied
yet. Also, LLVM isn't our code, so that isn't querified either. The plan is to
eventually query-fy all of the steps listed in the previous section,
but as of <!-- date-check --> November 2022, only the steps between `HIR` and
`LLVM-IR` are query-field. That is, lexing, parsing, name resolution, and macro
`LLVM-IR` are query-fied. That is, lexing, parsing, name resolution, and macro
expansion are done all at once for the whole program.

One other thing to mention here is the all-important "typing context",
Expand Down

0 comments on commit 6604b46

Please sign in to comment.