Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reset directory iteration in remove_dir_all #99937

Merged
merged 1 commit into from
Jul 30, 2022
Merged

Reset directory iteration in remove_dir_all #99937

merged 1 commit into from
Jul 30, 2022

Conversation

ChrisDenton
Copy link
Member

Fixes #99934

@rustbot
Copy link
Collaborator

rustbot commented Jul 30, 2022

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Jul 30, 2022
@rust-highfive
Copy link
Collaborator

@ChrisDenton: no appropriate reviewer found, use r? to override

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 30, 2022
@ChrisDenton
Copy link
Member Author

r? libs

@ChrisDenton ChrisDenton mentioned this pull request Jul 30, 2022
Closed
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jul 30, 2022

📌 Commit aac8a0a has been approved by joshtriplett

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 30, 2022
@matthiaskrgr matthiaskrgr mentioned this pull request Jul 30, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 30, 2022
@bors
Auto merge of rust-lang#99964 - matthiaskrgr:rollup-jr836e2, r=matthi…
0f4bcad 
…askrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#99650 (Support `x --keep-stage 0 check`)
 - rust-lang#99873 (rustdoc: align invalid-html-tags lint with commonmark spec)
 - rust-lang#99889 (Remove `parent_pat` from `TopInfo`)
 - rust-lang#99890 (Do not allow bad projection term to leak into the type checker)
 - rust-lang#99937 (Reset directory iteration in remove_dir_all)
 - rust-lang#99950 (Remove more Clean trait implementations)
 - rust-lang#99956 (Also gate AllocatedPointer and AllocAlign definitions by LLVM_VERSION_GE)
 - rust-lang#99962 (Discover channel for LLVM download)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 656cd3a into rust-lang:master Jul 30, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 30, 2022
@ChrisDenton ChrisDenton deleted the fix-remove-dir-all-win-7 branch July 31, 2022 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@joshtriplett joshtriplett

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.

std::fs::remove_dir_all() doesn't delete all files on Windows 7
5 participants
@ChrisDenton @rustbot @rust-highfive @joshtriplett @bors