-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #99816
Rollup of 7 pull requests #99816
Commits on Jul 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7919e42 - Browse repository at this point
Copy the full SHA 7919e42View commit details
Commits on Jul 25, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 1152e70 - Browse repository at this point
Copy the full SHA 1152e70View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1f54c3 - Browse repository at this point
Copy the full SHA c1f54c3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10b69ab - Browse repository at this point
Copy the full SHA 10b69abView commit details
Commits on Jul 26, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 91e91d8 - Browse repository at this point
Copy the full SHA 91e91d8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a2254d5 - Browse repository at this point
Copy the full SHA a2254d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ab63591 - Browse repository at this point
Copy the full SHA ab63591View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10be0dd - Browse repository at this point
Copy the full SHA 10be0ddView commit details -
Configuration menu - View commit details
-
Copy full SHA for ae70e36 - Browse repository at this point
Copy the full SHA ae70e36View commit details -
Configuration menu - View commit details
-
Copy full SHA for 267d362 - Browse repository at this point
Copy the full SHA 267d362View commit details -
Configuration menu - View commit details
-
Copy full SHA for 30565e5 - Browse repository at this point
Copy the full SHA 30565e5View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad1b181 - Browse repository at this point
Copy the full SHA ad1b181View commit details -
Configuration menu - View commit details
-
Copy full SHA for 556b027 - Browse repository at this point
Copy the full SHA 556b027View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2b8f0d - Browse repository at this point
Copy the full SHA e2b8f0dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4b2f06b - Browse repository at this point
Copy the full SHA 4b2f06bView commit details -
Configuration menu - View commit details
-
Copy full SHA for e2e3a88 - Browse repository at this point
Copy the full SHA e2e3a88View commit details
Commits on Jul 27, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 746afe8 - Browse repository at this point
Copy the full SHA 746afe8View commit details -
lint: add comment about diag lints in group
Add a brief comment explaining why the diagnostic migration lints aren't included in the `rustc::internal` diagnostic group. Signed-off-by: David Wood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 1b8e4b9 - Browse repository at this point
Copy the full SHA 1b8e4b9View commit details -
Add some comments to the docs issue template to clarify
Signed-off-by: Yuki Okushi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for e29ab16 - Browse repository at this point
Copy the full SHA e29ab16View commit details -
session: disable internal lints for rustdoc
If an internal lint uses `typeck_results` or similar queries then that can result in rustdoc checking code that it shouldn't (e.g. from other platforms) and emit compilation errors. Signed-off-by: David Wood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for f5e005f - Browse repository at this point
Copy the full SHA f5e005fView commit details -
lint: add bad opt access internal lint
Some command-line options accessible through `sess.opts` are best accessed through wrapper functions on `Session`, `TyCtxt` or otherwise, rather than through field access on the option struct in the `Session`. Adds a new lint which triggers on those options that should be accessed through a wrapper function so that this is prohibited. Options are annotated with a new attribute `rustc_lint_opt_deny_field_access` which can specify the error message (i.e. "use this other function instead") to be emitted. A simpler alternative would be to simply rename the options in the option type so that it is clear they should not be used, however this doesn't prevent uses, just discourages them. Another alternative would be to make the option fields private, and adding accessor functions on the option types, however the wrapper functions sometimes rely on additional state from `Session` or `TyCtxt` which wouldn't be available in an function on the option type, so the accessor would simply make the field available and its use would be discouraged too. Signed-off-by: David Wood <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for 7bab769 - Browse repository at this point
Copy the full SHA 7bab769View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4df8e78 - Browse repository at this point
Copy the full SHA 4df8e78View commit details -
Configuration menu - View commit details
-
Copy full SHA for 88b137d - Browse repository at this point
Copy the full SHA 88b137dView commit details -
Configuration menu - View commit details
-
Copy full SHA for bff43d0 - Browse repository at this point
Copy the full SHA bff43d0View commit details -
Rollup merge of rust-lang#94247 - saethlin:chunksmut-aliasing, r=the8472
Fix slice::ChunksMut aliasing Fixes rust-lang#94231, details in that issue. cc `@RalfJung` This isn't done just yet, all the safety comments are placeholders. But otherwise, it seems to work. I don't really like this approach though. There's a lot of unsafe code where there wasn't before, but as far as I can tell the only other way to uphold the aliasing requirement imposed by `__iterator_get_unchecked` is to use raw slices, which I think require the same amount of unsafe code. All that would do is tie the `len` and `ptr` fields together. Oh I just looked and I'm pretty sure that `ChunksExactMut`, `RChunksMut`, and `RChunksExactMut` also need to be patched. Even more reason to put up a draft.
Configuration menu - View commit details
-
Copy full SHA for ef81fca - Browse repository at this point
Copy the full SHA ef81fcaView commit details -
Rollup merge of rust-lang#99358 - compiler-errors:issue-99325, r=oli-obk
Allow `ValTree::try_to_raw_bytes` on `u8` array Fixes rust-lang#99325 cc `@b-naber` I think who touched this last in 705d818
Configuration menu - View commit details
-
Copy full SHA for 4ce1b0f - Browse repository at this point
Copy the full SHA 4ce1b0fView commit details -
Rollup merge of rust-lang#99651 - compiler-errors:fn-and-raw-ptr-in-c…
…onst-generics, r=oli-obk Deeply deny fn and raw ptrs in const generics I think this is right -- just because we wrap a fn ptr in a wrapper type does not mean we should allow it in a const parameter. We now reject both of these in the same way: ``` #![feature(adt_const_params)] #[derive(Eq, PartialEq)] struct Wrapper(); fn foo<const W: Wrapper>() {} fn foo2<const F: fn()>() {} ``` This does regress one test (`src/test/ui/consts/refs_check_const_eq-issue-88384.stderr`), but I'm not sure it should've passed in the first place. cc: ``@b-naber`` who introduced that test^ fixes rust-lang#99641
Configuration menu - View commit details
-
Copy full SHA for 9e7b7d5 - Browse repository at this point
Copy the full SHA 9e7b7d5View commit details -
Rollup merge of rust-lang#99710 - davidtwco:internal-lint-opts, r=lcnr
lint: add bad opt access internal lint Prompted by [Zulip discussion](https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/sess.2Ecrate_types.28.29.20vs.20sess.2Eopts.2Ecrate_types/near/290682847). Some command-line options accessible through `sess.opts` are best accessed through wrapper functions on `Session`, `TyCtxt` or otherwise, rather than through field access on the option struct in the `Session`. Adds a new lint which triggers on those options that should be accessed through a wrapper function so that this is prohibited. Options are annotated with a new attribute `rustc_lint_opt_deny_field_access` which can specify the error message (i.e. "use this other function instead") to be emitted. A simpler alternative would be to simply rename the options in the option type so that it is clear they should not be used, however this doesn't prevent uses, just discourages them. Another alternative would be to make the option fields private, and adding accessor functions on the option types, however the wrapper functions sometimes rely on additional state from `Session` or `TyCtxt` which wouldn't be available in an function on the option type, so the accessor would simply make the field available and its use would be discouraged too. **Leave a comment if there's an option I should add this to.**
Configuration menu - View commit details
-
Copy full SHA for dda74fe - Browse repository at this point
Copy the full SHA dda74feView commit details -
Rollup merge of rust-lang#99717 - JohnTitor:upd-docs-issue-tmpl, r=Ma…
…rk-Simulacrum Add some comments to the docs issue template to clarify Newcomers may not know that some docs have their own repositories (e.g. the book, the reference), or that the documentation and rustdoc are different. Actually, this template was used to report an issue related to the book: rust-lang#99699 This adds some comments to clarify the above things. I'm not sure if the current wording is the best, any suggestion would be helpful! Signed-off-by: Yuki Okushi <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for a7f4eb9 - Browse repository at this point
Copy the full SHA a7f4eb9View commit details -
Rollup merge of rust-lang#99728 - cjgillot:ast-lifetimes-anon-clean, …
…r=petrochenkov Clean up HIR-based lifetime resolution Based on rust-lang#97313. Fixes rust-lang#98932. r? `@petrochenkov`
Configuration menu - View commit details
-
Copy full SHA for c37ee1a - Browse repository at this point
Copy the full SHA c37ee1aView commit details -
Rollup merge of rust-lang#99812 - GuillaumeGomez:fix-headings-colors,…
… r=jsha,notriddle Fix headings colors Fixes rust-lang#99797. ![image](https://user-images.githubusercontent.com/3050060/181260966-49faf9d3-f6b8-4de4-bc7d-ed9f0467cf68.png) cc `@jsha` r? `@notriddle`
Configuration menu - View commit details
-
Copy full SHA for 2d52aa0 - Browse repository at this point
Copy the full SHA 2d52aa0View commit details