Allow patterns to constrain the hidden type of opaque types #99806

oli-obk · 2022-07-27T12:10:57Z

fixes #96572

reverts a revert as original PR was a perf regression that was fixed by reverting it: #99368 (comment))

TODO:

check if Binary size regression on msp430 due to #98582 #99685 is avoided

rust-highfive · 2022-07-27T12:11:01Z

r? @jackh726

(rust-highfive has picked a reviewer for you, use r? to override)

oli-obk · 2022-07-28T13:21:13Z

@bors try @rust-timer queue

rust-timer · 2022-07-28T13:21:15Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-28T13:21:21Z

⌛ Trying commit 459499fc9b0b46cca8fe035ab6c0c35d046e3065 with merge 3f31457bb3c0282484d0c1277e64f571afa882cd...

bors · 2022-07-28T15:12:04Z

☀️ Try build successful - checks-actions
Build commit: 3f31457bb3c0282484d0c1277e64f571afa882cd (3f31457bb3c0282484d0c1277e64f571afa882cd)

rust-timer · 2022-07-28T15:12:09Z

Queued 3f31457bb3c0282484d0c1277e64f571afa882cd with parent 48316df, future comparison URL.

rust-timer · 2022-07-28T16:28:40Z

Finished benchmarking commit (3f31457bb3c0282484d0c1277e64f571afa882cd): comparison url.

Instruction count

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	0.7%	2.9%	171
Regressions 😿 (secondary)	0.9%	5.8%	138
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.7%	2.9%	171

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regressions found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.6%	3.1%	3
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

Primary benchmarks: mixed results
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	2.2%	2.5%	2
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-2.3%	-2.3%	1
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	0.7%	2.5%	3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

bors · 2022-07-31T16:41:15Z

☔ The latest upstream changes (presumably #99979) made this pull request unmergeable. Please resolve the merge conflicts.

…rors Some `is_useful` cleanups rust-lang#98582 was reverted because it was a perf regression. rust-lang#99806 reintroduces the changes, but this PR picks individual ones that have no regressions.

oli-obk · 2022-08-31T13:15:00Z

@bors try @rust-timer queue

rust-timer · 2022-08-31T13:15:02Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-08-31T13:15:10Z

⌛ Trying commit 95dc7f8590787fb1a19e2c43174a522d575dfc78 with merge 6642984ad271a4e8d3ef4b40e65cb81333574b2f...

bors · 2022-08-31T14:38:05Z

☀️ Try build successful - checks-actions
Build commit: 6642984ad271a4e8d3ef4b40e65cb81333574b2f (6642984ad271a4e8d3ef4b40e65cb81333574b2f)

rust-timer · 2022-08-31T14:38:07Z

Queued 6642984ad271a4e8d3ef4b40e65cb81333574b2f with parent 12e4fd0, future comparison URL.

rust-timer · 2022-08-31T15:53:38Z

Finished benchmarking commit (6642984ad271a4e8d3ef4b40e65cb81333574b2f): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	0.7%	[0.2%, 3.2%]	120
Regressions ❌ (secondary)	1.2%	[0.2%, 6.2%]	76
Improvements ✅ (primary)	-0.4%	[-0.5%, -0.4%]	3
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[-0.5%, 3.2%]	123

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.7%	[2.1%, 3.4%]	4
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.3%	[-3.3%, -3.3%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	2.9%	[2.4%, 3.4%]	2
Improvements ✅ (primary)	-3.1%	[-3.1%, -3.1%]	1
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-0.4%	[-3.1%, 2.3%]	2

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

estebank · 2022-09-19T15:31:16Z

@bors r+ rollup=never

bors · 2022-09-19T15:31:19Z

📌 Commit dab1074 has been approved by estebank

It is now in the queue for this repository.

oli-obk · 2022-09-19T15:34:37Z

@bors r=estebank

bors · 2022-09-19T15:34:38Z

📌 Commit 1905f8c has been approved by estebank

It is now in the queue for this repository.

bors · 2022-09-20T06:25:46Z

⌛ Testing commit 1905f8c with merge 96e76bf486de500ea58ae9ec78dd9c386321aa0a...

rust-log-analyzer · 2022-09-20T08:24:04Z

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

oli-obk · 2022-09-20T08:30:52Z

@bors retry I can't find any failure in the logs, only cancelled builds

bors · 2022-09-20T12:09:55Z

⌛ Testing commit 1905f8c with merge 4136b59...

bors · 2022-09-20T15:49:24Z

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 4136b59 to master...

rust-timer · 2022-09-20T18:04:07Z

Finished benchmarking commit (4136b59): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.9%	[2.9%, 2.9%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-4.7%	[-4.7%, -4.7%]	1
All ❌✅ (primary)	-	-	0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean¹	range	count²
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	2.5%	[2.3%, 2.6%]	2
Improvements ✅ (primary)	-2.7%	[-3.2%, -2.2%]	2
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-2.7%	[-3.2%, -2.2%]	2

the arithmetic mean of the percent change ↩ ↩²
number of relevant changes ↩ ↩²

…estebank Allow patterns to constrain the hidden type of opaque types fixes rust-lang#96572 reverts a revert as original PR was a perf regression that was fixed by reverting it: rust-lang#99368 (comment)) TODO: * check if rust-lang#99685 is avoided

…ction, r=cjgillot Perform OpaqueCast field projection on HIR, too. fixes rust-lang#105819 This is necessary for closure captures in 2021 edition, as they capture individual fields, not the full mentioned variables. So it may try to capture a field of an opaque (because the hidden type is known to be something with a field). See rust-lang#99806 for when and why we added OpaqueCast to MIR.

…cjgillot Perform OpaqueCast field projection on HIR, too. fixes #105819 This is necessary for closure captures in 2021 edition, as they capture individual fields, not the full mentioned variables. So it may try to capture a field of an opaque (because the hidden type is known to be something with a field). See rust-lang/rust#99806 for when and why we added OpaqueCast to MIR.

Some `is_useful` cleanups #98582 was reverted because it was a perf regression. rust-lang/rust#99806 reintroduces the changes, but this PR picks individual ones that have no regressions.

rust-highfive assigned jackh726 Jul 27, 2022

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 27, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 27, 2022

oli-obk mentioned this pull request Jul 28, 2022

Some is_useful cleanups #99843

Merged

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 28, 2022

rustbot added perf-regression Performance regression. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jul 28, 2022

jackh726 added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 7, 2022

oli-obk force-pushed the unconstrained_opaque_type branch from fad4617 to 95dc7f8 Compare August 31, 2022 11:33

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Aug 31, 2022

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 31, 2022

rust-highfive assigned estebank and unassigned jackh726 Sep 19, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 19, 2022

Document projection condition

1905f8c

bors added the merged-by-bors This PR was explicitly merged by bors. label Sep 20, 2022

bors merged commit 4136b59 into rust-lang:master Sep 20, 2022

rustbot added this to the 1.66.0 milestone Sep 20, 2022

oli-obk deleted the unconstrained_opaque_type branch November 9, 2022 10:14

oli-obk mentioned this pull request Jul 24, 2023

Perform OpaqueCast field projection on HIR, too. #114022

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow patterns to constrain the hidden type of opaque types #99806

Allow patterns to constrain the hidden type of opaque types #99806

oli-obk commented Jul 27, 2022 •

edited

Loading

rust-highfive commented Jul 27, 2022

oli-obk commented Jul 28, 2022

rust-timer commented Jul 28, 2022

bors commented Jul 28, 2022

bors commented Jul 28, 2022

rust-timer commented Jul 28, 2022

rust-timer commented Jul 28, 2022

bors commented Jul 31, 2022

oli-obk commented Aug 31, 2022

rust-timer commented Aug 31, 2022

bors commented Aug 31, 2022

bors commented Aug 31, 2022

rust-timer commented Aug 31, 2022

rust-timer commented Aug 31, 2022

estebank commented Sep 19, 2022

bors commented Sep 19, 2022

oli-obk commented Sep 19, 2022

bors commented Sep 19, 2022

bors commented Sep 20, 2022

rust-log-analyzer commented Sep 20, 2022

oli-obk commented Sep 20, 2022

bors commented Sep 20, 2022

bors commented Sep 20, 2022

rust-timer commented Sep 20, 2022

Allow patterns to constrain the hidden type of opaque types #99806

Allow patterns to constrain the hidden type of opaque types #99806

Conversation

oli-obk commented Jul 27, 2022 • edited Loading

rust-highfive commented Jul 27, 2022

oli-obk commented Jul 28, 2022

rust-timer commented Jul 28, 2022

bors commented Jul 28, 2022

bors commented Jul 28, 2022

rust-timer commented Jul 28, 2022

rust-timer commented Jul 28, 2022

Footnotes

bors commented Jul 31, 2022

oli-obk commented Aug 31, 2022

rust-timer commented Aug 31, 2022

bors commented Aug 31, 2022

bors commented Aug 31, 2022

rust-timer commented Aug 31, 2022

rust-timer commented Aug 31, 2022

Overall result: ❌ regressions - ACTION NEEDED

Footnotes

estebank commented Sep 19, 2022

bors commented Sep 19, 2022

oli-obk commented Sep 19, 2022

bors commented Sep 19, 2022

bors commented Sep 20, 2022

rust-log-analyzer commented Sep 20, 2022

oli-obk commented Sep 20, 2022

bors commented Sep 20, 2022

bors commented Sep 20, 2022

rust-timer commented Sep 20, 2022

Overall result: no relevant changes - no action needed

Footnotes

oli-obk commented Jul 27, 2022 •

edited

Loading