use `FxIndexSet` for `region_bound_pairs` #99725

lcnr · 2022-07-25T16:32:01Z

should help with #99217 and might generally be a perf improvement.

r? types

lcnr · 2022-07-25T16:41:20Z

@bors try @rust-timer queue

rust-timer · 2022-07-25T16:41:21Z

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

bors · 2022-07-25T16:41:28Z

⌛ Trying commit 2e796ac with merge c806a63d71145dfc9d118c63fe11d086162304d4...

bors · 2022-07-25T18:38:50Z

☀️ Try build successful - checks-actions
Build commit: c806a63d71145dfc9d118c63fe11d086162304d4 (c806a63d71145dfc9d118c63fe11d086162304d4)

rust-timer · 2022-07-25T18:38:52Z

Queued c806a63d71145dfc9d118c63fe11d086162304d4 with parent 2fdbf07, future comparison URL.

rust-timer · 2022-07-25T19:54:34Z

Finished benchmarking commit (c806a63d71145dfc9d118c63fe11d086162304d4): comparison url.

Instruction count

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.3%	-0.4%	5
Improvements 🎉 (secondary)	-0.3%	-0.3%	1
All 😿🎉 (primary)	-0.3%	-0.4%	5

Max RSS (memory usage)

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.8%	2.8%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.6%	-2.6%	1
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: 🎉 relevant improvement found

	mean¹	max	count²
Regressions 😿 (primary)	4.3%	8.0%	8
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.4%	-2.4%	1
All 😿🎉 (primary)	4.3%	8.0%	8

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

compiler-errors · 2022-07-25T19:56:30Z

cool 🎉

@bors r+ rollup=never

bors · 2022-07-25T19:56:31Z

📌 Commit 2e796ac has been approved by compiler-errors

It is now in the queue for this repository.

bors · 2022-07-27T15:26:06Z

⌛ Testing commit 2e796ac with merge 0ec194b7af122526d0f8270498b3a5660f8c5ae2...

bors · 2022-07-27T15:31:54Z

💔 Test failed - checks-actions

lcnr · 2022-07-27T15:55:26Z

@bors retry

rust-log-analyzer · 2022-07-27T16:47:31Z

The job i686-msvc-1 failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)


#######################################                                   54.5%
######################################################################## 100.0%
Traceback (most recent call last):
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 943, in <module>
    found:    07946445625d74b7f8c0ddc07870b8da921ce186b781853b6c07112b7561ba5d
    expected: 35b4504603903e7c753487585fcc75237f4f8a0ee933c52941abaf2c6913e0f0
    main()
    main()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 926, in main
    bootstrap(help_triggered)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 901, in bootstrap
    build.download_toolchain()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 433, in download_toolchain
    self._download_component_helper(filename, pattern, tarball_suffix)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 464, in _download_component_helper
    get(
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 52, in get
    raise RuntimeError("failed verification")
make: *** [Makefile:58: prepare] Error 1
Command failed. Attempt 2/5:
D:\a\rust\rust\src\bootstrap\bootstrap.py:5: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  import distutils.version
  import distutils.version
downloading https://static.rust-lang.org/dist/2022-07-16/rust-std-beta-i686-pc-windows-msvc.tar.xz

##                                                                         3.6%
###########################################                               59.8%
######################################################################## 100.0%
Traceback (most recent call last):
invalid checksum:
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 943, in <module>
    expected: 35b4504603903e7c753487585fcc75237f4f8a0ee933c52941abaf2c6913e0f0
    main()
    main()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 926, in main
    bootstrap(help_triggered)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 901, in bootstrap
    build.download_toolchain()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 433, in download_toolchain
    self._download_component_helper(filename, pattern, tarball_suffix)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 464, in _download_component_helper
    get(
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 52, in get
    raise RuntimeError("failed verification")
make: *** [Makefile:58: prepare] Error 1
Command failed. Attempt 3/5:
D:\a\rust\rust\src\bootstrap\bootstrap.py:5: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  import distutils.version
  import distutils.version
downloading https://static.rust-lang.org/dist/2022-07-16/rust-std-beta-i686-pc-windows-msvc.tar.xz

#########                                                                 13.2%
#############################################################             85.1%
######################################################################## 100.0%
Traceback (most recent call last):
invalid checksum:
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 943, in <module>
    expected: 35b4504603903e7c753487585fcc75237f4f8a0ee933c52941abaf2c6913e0f0
    main()
    main()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 926, in main
    bootstrap(help_triggered)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 901, in bootstrap
    build.download_toolchain()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 433, in download_toolchain
    self._download_component_helper(filename, pattern, tarball_suffix)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 464, in _download_component_helper
    get(
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 52, in get
    raise RuntimeError("failed verification")
make: *** [Makefile:58: prepare] Error 1
Command failed. Attempt 4/5:
D:\a\rust\rust\src\bootstrap\bootstrap.py:5: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  import distutils.version
  import distutils.version
downloading https://static.rust-lang.org/dist/2022-07-16/rust-std-beta-i686-pc-windows-msvc.tar.xz

##############                                                            20.5%
######################################################################## 100.0%
Traceback (most recent call last):
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 943, in <module>
    found:    07946445625d74b7f8c0ddc07870b8da921ce186b781853b6c07112b7561ba5d
    expected: 35b4504603903e7c753487585fcc75237f4f8a0ee933c52941abaf2c6913e0f0
    main()
    main()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 926, in main
    bootstrap(help_triggered)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 901, in bootstrap
    build.download_toolchain()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 433, in download_toolchain
    self._download_component_helper(filename, pattern, tarball_suffix)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 464, in _download_component_helper
    get(
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 52, in get
    raise RuntimeError("failed verification")
make: *** [Makefile:58: prepare] Error 1
Command failed. Attempt 5/5:
D:\a\rust\rust\src\bootstrap\bootstrap.py:5: DeprecationWarning: The distutils package is deprecated and slated for removal in Python 3.12. Use setuptools or check PEP 632 for potential alternatives
  import distutils.version
  import distutils.version
downloading https://static.rust-lang.org/dist/2022-07-16/rust-std-beta-i686-pc-windows-msvc.tar.xz

############                                                              17.6%
######################################################################## 100.0%
Traceback (most recent call last):
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 943, in <module>
    found:    07946445625d74b7f8c0ddc07870b8da921ce186b781853b6c07112b7561ba5d
    expected: 35b4504603903e7c753487585fcc75237f4f8a0ee933c52941abaf2c6913e0f0
    main()
    main()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 926, in main
    bootstrap(help_triggered)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 901, in bootstrap
    build.download_toolchain()
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 433, in download_toolchain
    self._download_component_helper(filename, pattern, tarball_suffix)
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 464, in _download_component_helper
    get(
  File "D:\a\rust\rust\src\bootstrap\bootstrap.py", line 52, in get
    raise RuntimeError("failed verification")
make: *** [Makefile:58: prepare] Error 1
The command has failed after 5 attempts.

lcnr · 2022-07-27T17:27:34Z

same issue again afaict? cc @rust-lang/infra

@bors retry

bors · 2022-07-27T22:02:17Z

⌛ Testing commit 2e796ac with merge ada80a1...

bors · 2022-07-28T00:43:05Z

☀️ Test successful - checks-actions
Approved by: compiler-errors
Pushing ada80a1 to master...

rust-timer · 2022-07-28T03:14:04Z

Finished benchmarking commit (ada80a1): comparison url.

Instruction count

Primary benchmarks: 🎉 relevant improvements found
Secondary benchmarks: no relevant changes found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-0.3%	-0.3%	2
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.3%	-0.3%	2

Max RSS (memory usage)

Results

Primary benchmarks: 😿 relevant regressions found
Secondary benchmarks: mixed results

	mean¹	max	count²
Regressions 😿 (primary)	1.9%	2.3%	12
Regressions 😿 (secondary)	2.9%	2.9%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-3.0%	-4.0%	2
All 😿🎉 (primary)	1.9%	2.3%	12

Cycles

Results

Primary benchmarks: no relevant changes found
Secondary benchmarks: 😿 relevant regression found

	mean¹	max	count²
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	2.1%	2.1%	1
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

the arithmetic mean of the percent change ↩ ↩² ↩³
number of relevant changes ↩ ↩² ↩³

rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jul 25, 2022

rust-highfive assigned compiler-errors Jul 25, 2022

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jul 25, 2022

use FxIndexSet for region_bound_pairs

2e796ac

lcnr force-pushed the dedup-region_bound_pairs branch from 8224cf7 to 2e796ac Compare July 25, 2022 16:39

rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 25, 2022

rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jul 25, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 25, 2022

lcnr mentioned this pull request Jul 26, 2022

consider unnormalized types for implied bounds #99217

Merged

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 27, 2022

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 27, 2022

bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 28, 2022

bors merged commit ada80a1 into rust-lang:master Jul 28, 2022

rustbot added this to the 1.64.0 milestone Jul 28, 2022

bors mentioned this pull request Jul 28, 2022

get rid of RefCell in TransitiveRelation #99702

Merged

lcnr deleted the dedup-region_bound_pairs branch July 28, 2022 05:14

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

use `FxIndexSet` for `region_bound_pairs` #99725

use `FxIndexSet` for `region_bound_pairs` #99725

lcnr commented Jul 25, 2022

lcnr commented Jul 25, 2022

rust-timer commented Jul 25, 2022

bors commented Jul 25, 2022

bors commented Jul 25, 2022

rust-timer commented Jul 25, 2022

rust-timer commented Jul 25, 2022

compiler-errors commented Jul 25, 2022

bors commented Jul 25, 2022

bors commented Jul 27, 2022

bors commented Jul 27, 2022

lcnr commented Jul 27, 2022

rust-log-analyzer commented Jul 27, 2022

lcnr commented Jul 27, 2022

bors commented Jul 27, 2022

bors commented Jul 28, 2022

rust-timer commented Jul 28, 2022

use FxIndexSet for region_bound_pairs #99725

use FxIndexSet for region_bound_pairs #99725

Conversation

lcnr commented Jul 25, 2022

lcnr commented Jul 25, 2022

rust-timer commented Jul 25, 2022

bors commented Jul 25, 2022

bors commented Jul 25, 2022

rust-timer commented Jul 25, 2022

rust-timer commented Jul 25, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

compiler-errors commented Jul 25, 2022

bors commented Jul 25, 2022

bors commented Jul 27, 2022

bors commented Jul 27, 2022

lcnr commented Jul 27, 2022

rust-log-analyzer commented Jul 27, 2022

lcnr commented Jul 27, 2022

bors commented Jul 27, 2022

bors commented Jul 28, 2022

rust-timer commented Jul 28, 2022

Instruction count

Max RSS (memory usage)

Cycles

Footnotes

use `FxIndexSet` for `region_bound_pairs` #99725

use `FxIndexSet` for `region_bound_pairs` #99725