Miscellaneous inlining improvements

[tmiasko]

Add #[inline] to a few trivial non-generic methods from a perf report
that otherwise wouldn't be candidates for inlining.

[rust-highfive]

r? @estebank

(rust-highfive has picked a reviewer for you, use r? to override)

[compiler-errors]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[bors]

⌛ Trying commit 87374de with merge e30db7aa9aa2bcbb1ee9d57b6c26e0fa9c522740...

[bors]

☀️ Try build successful - checks-actions
Build commit: e30db7aa9aa2bcbb1ee9d57b6c26e0fa9c522740 (e30db7aa9aa2bcbb1ee9d57b6c26e0fa9c522740)

[rust-timer]

Queued e30db7aa9aa2bcbb1ee9d57b6c26e0fa9c522740 with parent 3e51277, future comparison URL.

[rust-timer]

Finished benchmarking commit (e30db7aa9aa2bcbb1ee9d57b6c26e0fa9c522740): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	0.3%	0.4%	7
Improvements 🎉 (primary)	-0.4%	-0.9%	121
Improvements 🎉 (secondary)	-0.6%	-1.2%	64
All 😿🎉 (primary)	-0.4%	-0.9%	121

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

Results

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: 🎉 relevant improvements found

	mean1	max	count2
Regressions 😿 (primary)	2.1%	2.1%	1
Regressions 😿 (secondary)	N/A	N/A	0
Improvements 🎉 (primary)	-1.9%	-3.0%	10
Improvements 🎉 (secondary)	-2.2%	-2.5%	6
All 😿🎉 (primary)	-1.5%	-3.0%	11

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²

[estebank]

Nothing huge, but pretty consistent win. CC @nnethercote

@bors r+

[bors]

📌 Commit 87374de has been approved by estebank

It is now in the queue for this repository.

[nnethercote]

Nice work. Which profiler did you use to find these?

[bors]

⌛ Testing commit 87374de with merge 86b8dd5...

[bors]

☀️ Test successful - checks-actions
Approved by: estebank
Pushing 86b8dd5 to master...

[rust-timer]

Finished benchmarking commit (86b8dd5): comparison url.

Instruction count

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	0.7%	1.4%	13
Improvements 🎉 (primary)	-0.4%	-0.9%	124
Improvements 🎉 (secondary)	-0.5%	-1.0%	62
All 😿🎉 (primary)	-0.4%	-0.9%	124

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: 😿 relevant regressions found

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.8%	2.7%	2
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: 🎉 relevant improvements found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	1.7%	1.7%	1
Improvements 🎉 (primary)	-2.1%	-3.7%	15
Improvements 🎉 (secondary)	-2.9%	-3.3%	2
All 😿🎉 (primary)	-2.1%	-3.7%	15

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩² ↩³

2. number of relevant changes ↩ ↩² ↩³

[tmiasko]

Nice work. Which profiler did you use to find these?

perf