Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 6 pull requests #98820

Merged
merged 12 commits into from
Jul 2, 2022
Merged

Rollup of 6 pull requests #98820

merged 12 commits into from
Jul 2, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jul 2, 2022

TaKO8Ki and others added 12 commits June 30, 2022 13:43
Previously, it required you to manually run `x build` first, because it
assumed the LLVM binaries were already present.
…crum

Fix `x dist rust-dev` on a fresh checkout

Previously, it required you to manually run `x build` first, because it
assumed the LLVM binaries were already present.
Add rust-lang#95469 to the release notes

rust-lang#95469 may break programs using async file handles so it should've been noted in compatibility notes (sorry).
…acrum

feat: Add a documentation problem issue template

Fixes rust-lang#98722 :)
@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Jul 2, 2022
@RalfJung
Copy link
Member Author

RalfJung commented Jul 2, 2022

@bors r+ p=5

@bors
Copy link
Contributor

bors commented Jul 2, 2022

📌 Commit 434ce76 has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jul 2, 2022
@bors
Copy link
Contributor

bors commented Jul 2, 2022

⌛ Testing commit 434ce76 with merge f2d9393...

@bors
Copy link
Contributor

bors commented Jul 2, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing f2d9393 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 2, 2022
@bors bors merged commit f2d9393 into rust-lang:master Jul 2, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jul 2, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #98820!

Tested on commit f2d9393.
Direct link to PR: #98820

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @RalfJung).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jul 2, 2022
Tested on commit rust-lang/rust@f2d9393.
Direct link to PR: <rust-lang/rust#98820>

🎉 miri on windows: test-fail → test-pass (cc @oli-obk @RalfJung).
🎉 miri on linux: test-fail → test-pass (cc @oli-obk @RalfJung).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f2d9393): comparison url.

Instruction count

  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
0.9% 1.0% 2
Regressions 😿
(secondary)
2.1% 2.5% 6
Improvements 🎉
(primary)
-0.3% -0.6% 7
Improvements 🎉
(secondary)
-0.5% -0.6% 7
All 😿🎉 (primary) -0.0% 1.0% 9

Max RSS (memory usage)

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
3.5% 3.5% 2
Regressions 😿
(secondary)
2.3% 2.3% 1
Improvements 🎉
(primary)
-1.1% -1.2% 2
Improvements 🎉
(secondary)
-3.6% -3.6% 1
All 😿🎉 (primary) 1.2% 3.5% 4

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)
4.5% 4.5% 1
Regressions 😿
(secondary)
N/A N/A 0
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
N/A N/A 0
All 😿🎉 (primary) 4.5% 4.5% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression

Footnotes

  1. the arithmetic mean of the percent change 2 3

  2. number of relevant changes 2 3

@rustbot rustbot added the perf-regression Performance regression. label Jul 3, 2022
@klensy
Copy link
Contributor

klensy commented Jul 3, 2022

@RalfJung RalfJung deleted the rollup-i3mip9a branch July 3, 2022 11:42
@Mark-Simulacrum Mark-Simulacrum removed the perf-regression Performance regression. label Jul 5, 2022
@Mark-Simulacrum
Copy link
Member

Based on a wider view of benchmarks over the last week, fairly certain these results were noise -- probably some new non-determinism has snuck in. Dropping regression label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.