Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove some redundant checks from BufReader #98748

Merged
merged 4 commits into from
Jul 27, 2022
Merged

Remove some redundant checks from BufReader #98748

merged 4 commits into from
Jul 27, 2022
+134 −53

Commits on Jul 24, 2022

  1. Remove some redundant checks from BufReader 

    The implementation of BufReader contains a lot of redundant checks.
While any one of these checks is not particularly expensive to execute,
especially when taken together they dramatically inhibit LLVM's ability
to make subsequent optimizations.
    @saethlin
    saethlin committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    761ddf3 View commit details
    Browse the repository at this point in the history

  2. Allow Buffer methods to inline

    @saethlin
    saethlin committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    b9497be View commit details
    Browse the repository at this point in the history

  3. Rename and document the new BufReader internals

    @saethlin
    saethlin committed Jul 24, 2022
    Configuration menu
    Copy the full SHA
    5e5ce43 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Add Buffer::consume_with to enable direct buffer access with one check

    @saethlin
    saethlin committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    5fa1926 View commit details
    Browse the repository at this point in the history