rustdoc: reference function signature types from the p array

[notriddle]

This reduces the size of the function signature index, because it's common to have many functions that operate on the same types.

$ wc -c search-index-old.js search-index-new.js
5224374 search-index-old.js
3932314 search-index-new.js

By my math, this reduces the uncompressed size of the search index by 32%.
On compressed signatures, the wins are less drastic, a mere 8%:

$ wc -c search-index-old.js.gz search-index-new.js.gz
404532 search-index-old.js.gz
371635 search-index-new.js.gz

[rust-highfive]

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

Some changes occurred in clean/types.rs.

cc @camelid

[rust-highfive]

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

[GuillaumeGomez]

Changes look good to me. Do you have an online version by any chance?

[notriddle]

@GuillaumeGomez

https://notriddle.com/notriddle-rustdoc-test/search-p/

[Folyd]

This is so good. I hope this PR wouldn't break my extension, haha. 😄

[notriddle]

This is so good. I hope this PR wouldn't break my extension, haha. 😄

It depends on whether you use the f array, which contains the data used by Input -> Output style searches. If you only support searching by name, then this shouldn't affect you at all.

[GuillaumeGomez]

Still this question:

Btw, why 0 and not null?

Apart from that, looks really great. :)

[notriddle]

Btw, why 0 and not null?

null is four bytes, while 0 is one byte.

[GuillaumeGomez]

Please add this explanation then. :)

[GuillaumeGomez]

Thanks, it's awesome! r=me once CI pass.

[notriddle]

@bors r=GuillaumeGomez rollup=never

This might have a perf impact. Even if it's a sizeable regression, it would probably be worth it, but we still don't want it included in a rollup.

[bors]

📌 Commit 33cf9ea has been approved by GuillaumeGomez

[bors]

⌛ Testing commit 33cf9ea with merge 2953edc...

[bors]

☀️ Test successful - checks-actions
Approved by: GuillaumeGomez
Pushing 2953edc to master...

[rust-timer]

Finished benchmarking commit (2953edc): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

• Primary benchmarks: no relevant changes found
• Secondary benchmarks: mixed results

	mean1	max	count2
Regressions 😿 (primary)	N/A	N/A	0
Regressions 😿 (secondary)	3.1%	3.5%	3
Improvements 🎉 (primary)	N/A	N/A	0
Improvements 🎉 (secondary)	-2.1%	-2.1%	1
All 😿🎉 (primary)	N/A	N/A	0

Cycles

Results

• Primary benchmarks: mixed results
• Secondary benchmarks: 😿 relevant regression found

	mean1	max	count2
Regressions 😿 (primary)	3.1%	3.1%	1
Regressions 😿 (secondary)	2.5%	2.5%	1
Improvements 🎉 (primary)	-2.8%	-3.2%	2
Improvements 🎉 (secondary)	N/A	N/A	0
All 😿🎉 (primary)	-0.9%	-3.2%	3

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

1. the arithmetic mean of the percent change ↩ ↩²

2. number of relevant changes ↩ ↩²