Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not access HIR to check impl wf. #98396

Merged
merged 2 commits into from
Jun 28, 2022
Merged

Do not access HIR to check impl wf. #98396

merged 2 commits into from
Jun 28, 2022

Conversation

cjgillot
Copy link
Contributor

r? @ghost

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 22, 2022
@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Jun 22, 2022
@bors
Copy link
Contributor

bors commented Jun 22, 2022

⌛ Trying commit 3dec3987fd94457ffe60b70a64f66235aeab777a with merge 23707eda8edba729e4869029cbe70b23fa4a9881...

deltragon
deltragon reviewed Jun 22, 2022
View reviewed changes
compiler/rustc_typeck/src/impl_wf_check.rs Outdated
Occupied(entry) => {
let mut err = struct_span_err!(
tcx.sess,
impl_item.span,
tcx.def_span(impl_item_ref),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
tcx.def_span(impl_item_ref),
span,

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably still needs rustfmt after this, might fit on a single line now

@cjgillot
Copy link
Contributor Author

@bors try @rust-timer queue

@rust-timer
Copy link
Collaborator

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

@bors
Copy link
Contributor

bors commented Jun 23, 2022

⌛ Trying commit 471fdf8152b40fc91e58477522060ade1db6c2cd with merge f580c6643fdc946abb1320c5206361bd0b0d753f...

@bors
Copy link
Contributor

bors commented Jun 23, 2022

☀️ Try build successful - checks-actions
Build commit: f580c6643fdc946abb1320c5206361bd0b0d753f (f580c6643fdc946abb1320c5206361bd0b0d753f)

@rust-timer
Copy link
Collaborator

Queued f580c6643fdc946abb1320c5206361bd0b0d753f with parent 10f4ce3, future comparison URL.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f580c6643fdc946abb1320c5206361bd0b0d753f): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -1.9% -1.9% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -1.9% -1.9% 1

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 2.0% 2.0% 1
Regressions 😿
(secondary)		 2.5% 2.6% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 2.0% 2.0% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: +S-waiting-on-review -S-waiting-on-perf -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-perf Status: Waiting on a perf run to be completed. labels Jun 23, 2022
@cjgillot cjgillot marked this pull request as ready for review June 24, 2022 05:50
@cjgillot
Copy link
Contributor Author

r? rust-lang/compiler

@petrochenkov
Copy link
Contributor

r=me with #98396 (comment) addressed.
@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 24, 2022
@cjgillot
Copy link
Contributor Author

@bors r=petrochenkov

@bors
Copy link
Contributor

bors commented Jun 24, 2022

📌 Commit 8242aa8 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 24, 2022
@bors
Copy link
Contributor

bors commented Jun 28, 2022

⌛ Testing commit 8242aa8 with merge baf382e...

@bors
Copy link
Contributor

bors commented Jun 28, 2022

☀️ Test successful - checks-actions
Approved by: petrochenkov
Pushing baf382e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 28, 2022
@bors bors merged commit baf382e into rust-lang:master Jun 28, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 28, 2022
This was referenced Jun 28, 2022
Merged
Merged
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (baf382e): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: 😿 relevant regressions found
mean1 max count2
Regressions 😿
(primary)		 2.0% 2.0% 1
Regressions 😿
(secondary)		 2.9% 3.2% 2
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) 2.0% 2.0% 1

Cycles

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 2.5% 2.5% 1
Improvements 🎉
(primary)		 -3.3% -3.3% 1
Improvements 🎉
(secondary)		 -2.7% -2.7% 1
All 😿🎉 (primary) -3.3% -3.3% 1

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩ ↩2

  2. number of relevant changes ↩ ↩2

@cjgillot cjgillot deleted the iwfchir branch June 28, 2022 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltragon deltragon deltragon left review comments

Assignees

@petrochenkov petrochenkov

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.64.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cjgillot @rust-timer @bors @petrochenkov @deltragon @rustbot