Point to type parameter definition when not finding variant, method and associated item #98298
Conversation
rustbot
added
the
T-compiler
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
TaKO8Ki
force-pushed
the
point-to-type-param-definition
branch
from
b6e51f0
to
0fc385b
Compare
TaKO8Ki
force-pushed
the
point-to-type-param-definition
branch
from
9dcc5d5
to
4a82fbb
Compare
This comment has been minimized.
This comment has been minimized.
TaKO8Ki
force-pushed
the
point-to-type-param-definition
branch
from
4a82fbb
to
82e4e6d
Compare
|
r? @compiler-errors, if that's OK. |
| let generics = self.tcx.generics_of( | ||
| tcx.hir() | ||
| .body_owner_def_id(hir::BodyId { hir_id: self.body_id }) | ||
| .to_def_id(), |
There was a problem hiding this comment.
Sorry, I overcomplicated this. Instead of tcx.hir().body_owner_def_id(..), let's just do self.body_id.owner.to_def_id() -- I've seen this being used elsewhere in typeck.
| ); | ||
| let type_param = generics.type_param(param_type, self.tcx); | ||
| Some((self.tcx.def_span(type_param.def_id), "for this")) |
There was a problem hiding this comment.
We have a def-id, do you think it's useful to use self.def_kind(def_id).descr() so we can say "for this type parameter" or "for this enum" below?
There was a problem hiding this comment.
I think it is useful. I will implement it.
There was a problem hiding this comment.
Hmm. I am beginning to think it might be redundant.
There was a problem hiding this comment.
Hm, why so? I don't know why this is more clear (current):
LL | struct Foo {
| --- method `clone` not found for this
Than this (with the change):
LL | struct Foo {
| --- method `clone` not found for this struct
The "this" feels incomplete.
There was a problem hiding this comment.
I think at least we should be saying "for this type parameter" in this case, even if we don't add the def_kind(def_id).descr() in the ADT case below.
There was a problem hiding this comment.
Ok. I will implement it 👍
|
After the review, I will squash my commits. |
|
@bors delegate+ |
|
✌️ @TaKO8Ki can now approve this pull request |
…ssoc type use `def_ident_span` , `body_owner_def_id` instead of `in_progress_typeck_results`, `guess_head_span` use `body_id.owner` directly add description to label
TaKO8Ki
force-pushed
the
point-to-type-param-definition
branch
from
d7e4caa
to
402dceb
Compare
|
@bors r=compiler-errors |
|
📌 Commit 402dceb has been approved by |
bors
added
S-waiting-on-bors
…ion, r=compiler-errors Point to type parameter definition when not finding variant, method and associated item fixes rust-lang#77391
…ion, r=compiler-errors Point to type parameter definition when not finding variant, method and associated item fixes rust-lang#77391
…askrgr Rollup of 9 pull requests Successful merges: - rust-lang#96412 (Windows: Iterative `remove_dir_all`) - rust-lang#98126 (Mitigate MMIO stale data vulnerability) - rust-lang#98149 (Set relocation_model to Pic on emscripten target) - rust-lang#98194 (Leak pthread_{mutex,rwlock}_t if it's dropped while locked.) - rust-lang#98298 (Point to type parameter definition when not finding variant, method and associated item) - rust-lang#98311 (Reverse folder hierarchy) - rust-lang#98401 (Add tracking issues to `--extern` option docs.) - rust-lang#98429 (Use correct substs in enum discriminant cast) - rust-lang#98431 (Suggest defining variable as mutable on `&mut _` type mismatch in pats) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
fixes #77391