Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebase LLVM submodule #98285

Merged
merged 1 commit into from
Jun 27, 2022
Merged

Rebase LLVM submodule #98285

merged 1 commit into from
Jun 27, 2022

Conversation

nikic
Copy link
Contributor

@nikic nikic commented Jun 20, 2022

This is a rebase of our LLVM fork onto LLVM 14.0.5, which is intended to be the last release of the 14.x series. Additionally:

@rust-highfive
Copy link
Collaborator

r? @Mark-Simulacrum

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 20, 2022
@nikic
Copy link
Contributor Author

nikic commented Jun 20, 2022

r? @cuviper

@cuviper
Copy link
Member

cuviper commented Jun 21, 2022

@tstellar tells me there will be a 14.0.6 this week, so I suppose we should hold for that. Maybe your additional cherry-pick can sneak in there as well?

@nikic
Copy link
Contributor Author

nikic commented Jun 21, 2022

I don't think I can force-push rust-lang/llvm-project, so I'd probably keep this branch and merge additional commits if needed. I opened llvm/llvm-project#56150 for the upstream cherry-pick though.

@nikic
Copy link
Contributor Author

nikic commented Jun 25, 2022

Okay, looks like the 14.0.6 release is a very small one (https://discourse.llvm.org/t/llvm-14-0-6-release/63431), that fixes an AVR regression in clang. I've merged the three new commits.

@cuviper
Copy link
Member

cuviper commented Jun 25, 2022

@bors r+ rollup=never

@bors
Copy link
Contributor

bors commented Jun 25, 2022

📌 Commit 6e6b3ea has been approved by cuviper

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 25, 2022
@bors
Copy link
Contributor

bors commented Jun 27, 2022

⌛ Testing commit 6e6b3ea with merge bd2e51a...

@slanterns slanterns mentioned this pull request Jun 27, 2022
@bors
Copy link
Contributor

bors commented Jun 27, 2022

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing bd2e51a to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 27, 2022
@bors bors merged commit bd2e51a into rust-lang:master Jun 27, 2022
@rustbot rustbot added this to the 1.64.0 milestone Jun 27, 2022
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (bd2e51a): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: mixed results
mean1 max count2
Regressions 😿
(primary)
N/A N/A 0
Regressions 😿
(secondary)
2.8% 2.8% 1
Improvements 🎉
(primary)
N/A N/A 0
Improvements 🎉
(secondary)
-2.0% -2.0% 1
All 😿🎉 (primary) N/A N/A 0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change

  2. number of relevant changes

@Amanieu Amanieu mentioned this pull request Jul 8, 2022
Amanieu added a commit to Amanieu/rust that referenced this pull request Jul 12, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jul 18, 2022
Amanieu added a commit to Amanieu/rust that referenced this pull request Jul 21, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants