Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Miri #97916

Merged
merged 1 commit into from
Jun 9, 2022
Merged

update Miri #97916

merged 1 commit into from
Jun 9, 2022

Conversation

RalfJung
Copy link
Member

@RalfJung RalfJung commented Jun 9, 2022

Fixes #97886
Cc @rust-lang/miri r? @ghost

@RalfJung
Copy link
Member Author

RalfJung commented Jun 9, 2022

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Jun 9, 2022

📌 Commit 8c41c6f has been approved by RalfJung

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 9, 2022
@bors
Copy link
Contributor

bors commented Jun 9, 2022

⌛ Testing commit 8c41c6f with merge d7b8d77...

@bors
Copy link
Contributor

bors commented Jun 9, 2022

☀️ Test successful - checks-actions
Approved by: RalfJung
Pushing d7b8d77 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 9, 2022
@bors bors merged commit d7b8d77 into rust-lang:master Jun 9, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 9, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #97916!

Tested on commit d7b8d77.
Direct link to PR: #97916

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @eddyb @oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @eddyb @oli-obk).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request Jun 9, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#97916!
16935df 
Tested on commit rust-lang/rust@d7b8d77.
Direct link to PR: <rust-lang/rust#97916>

🎉 miri on windows: build-fail → test-pass (cc @RalfJung @eddyb @oli-obk).
🎉 miri on linux: build-fail → test-pass (cc @RalfJung @eddyb @oli-obk).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (d7b8d77): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: no relevant changes found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 -2.1% -2.1% 1
Improvements 🎉
(secondary)		 N/A N/A 0
All 😿🎉 (primary) -2.1% -2.1% 1

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@RalfJung RalfJung mentioned this pull request Jun 11, 2022
Closed
@RalfJung RalfJung deleted the miri branch June 14, 2022 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.

miri no longer builds after rust-lang/rust#97873
5 participants
@RalfJung @bors @rust-highfive @rust-timer @rustbot