Skip to content

Remove duplicated implementations of borrowed locals analysis #97833

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bors merged 2 commits into from
Jun 12, 2022
Merged

Remove duplicated implementations of borrowed locals analysis #97833

bors merged 2 commits into from
Jun 12, 2022

Conversation

@tmiasko
Copy link
Contributor

@tmiasko tmiasko commented Jun 7, 2022

No description provided.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Jun 7, 2022
@rust-highfive
Copy link
Contributor

rust-highfive commented Jun 7, 2022

r? @nagisa

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 7, 2022
@nagisa
Copy link
Member

nagisa commented Jun 11, 2022

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 11, 2022

📌 Commit ef2f32a3d1a53a597f6f9b9323eaaa77471a1e46 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 11, 2022
@bors
Copy link
Collaborator

bors commented Jun 12, 2022

⌛ Testing commit ef2f32a3d1a53a597f6f9b9323eaaa77471a1e46 with merge 4614e3b503b6fbe49b504378f9b862fe12c6a1ef...

@bors
Copy link
Collaborator

bors commented Jun 12, 2022

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 12, 2022
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@tmiasko
Copy link
Contributor Author

tmiasko commented Jun 12, 2022

Rebased and fixed the doc-link.

@bors r=nagisa

@bors
Copy link
Collaborator

bors commented Jun 12, 2022

📌 Commit 777bf84 has been approved by nagisa

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 12, 2022
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Jun 12, 2022
@Dylan-DPC
Rollup merge of rust-lang#97833 - tmiasko:borrowed-locals, r=nagisa
98af36a 
Remove duplicated implementations of borrowed locals analysis
@Dylan-DPC Dylan-DPC mentioned this pull request Jun 12, 2022
Closed
@bors
Copy link
Collaborator

bors commented Jun 12, 2022

⌛ Testing commit 777bf84 with merge 4153a2e...

@bors
Copy link
Collaborator

bors commented Jun 12, 2022

☀️ Test successful - checks-actions
Approved by: nagisa
Pushing 4153a2e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 12, 2022
@bors bors merged commit 4153a2e into rust-lang:master Jun 12, 2022
@rustbot rustbot added this to the 1.63.0 milestone Jun 12, 2022
@rust-timer
Copy link
Collaborator

rust-timer commented Jun 12, 2022

Finished benchmarking commit (4153a2e): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
mean1 max count2
Regressions 😿
(primary)		 N/A N/A 0
Regressions 😿
(secondary)		 N/A N/A 0
Improvements 🎉
(primary)		 N/A N/A 0
Improvements 🎉
(secondary)		 -3.2% -4.1% 2
All 😿🎉 (primary) N/A N/A 0

Cycles

This benchmark run did not return any relevant results for this metric.

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. the arithmetic mean of the percent change ↩

  2. number of relevant changes ↩

@tmiasko tmiasko deleted the borrowed-locals branch June 13, 2022 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@nagisa nagisa

Labels

merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.63.0

Development

Successfully merging this pull request may close these issues.

7 participants

@tmiasko @rust-highfive @nagisa @bors @rust-log-analyzer @rust-timer @rustbot