Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide irrelevant lines in suggestions to allow for suggestions that are far from each other to be shown #97798

Merged
merged 6 commits into from
Jun 17, 2022
Merged

Hide irrelevant lines in suggestions to allow for suggestions that are far from each other to be shown #97798

merged 6 commits into from
Jun 17, 2022

Commits on Jun 16, 2022

  1. Fix a typo 

    !(a & b) = !a | !b
    @WaffleLapkin
    WaffleLapkin committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    260c5fd View commit details
    Browse the repository at this point in the history

  2. Improve suggestions when its parts are far from each other 

    Previously we only show at most 6 lines of suggestions and, if the
suggestions are more than 6 lines apart, we've just showed ... at the
end. This is probably fine, but quite confusing in my opinion.

This commit is an attempt to show ... in places where there is nothing
to suggest instead, for example:

Before:
```text
help: consider enclosing expression in a block
  |
3 ~     'l: { match () { () => break 'l,
4 |
5 |
6 |
7 |
8 |
...
```

After:
```text
help: consider enclosing expression in a block
  |
3 ~     'l: { match () { () => break 'l,
4 |
...
31|
32~ } };
  |
```
    @WaffleLapkin
    WaffleLapkin committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    87fded1 View commit details
    Browse the repository at this point in the history

  3. --bless ui

    @WaffleLapkin
    WaffleLapkin committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    a607cff View commit details
    Browse the repository at this point in the history

  4. Try to clean up code... 

    I'm not sure if I succeeded
    @WaffleLapkin
    WaffleLapkin committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    cf6f821 View commit details
    Browse the repository at this point in the history

  5. Add back MAX_SUGGESTION_HIGHLIGHT_LINES so clippy is happy & buildable

    @WaffleLapkin
    WaffleLapkin committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    3c55672 View commit details
    Browse the repository at this point in the history

  6. bless clippy ui tests

    @WaffleLapkin
    WaffleLapkin committed Jun 16, 2022
    Configuration menu
    Copy the full SHA
    e502b9a View commit details
    Browse the repository at this point in the history