Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve soundness of rustc_data_structures #97707

Merged
merged 2 commits into from
Jun 5, 2022
Merged

Improve soundness of rustc_data_structures #97707

merged 2 commits into from
Jun 5, 2022

Commits on Jun 4, 2022

  1. Adapt rustc_data_structures tests to run in strict miri 

    Some tests took too long and owning_ref is fundamentally flawed,
so don't run these tests or run them with a shorter N. This makes
miri with `-Zmiri-strict-provenance` usable to find UB.
    @Noratrieb
    Noratrieb committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    fc8b13c View commit details
    Browse the repository at this point in the history

  2. Fix stacked borrows invalidation in rustc_data_structures sip128 

    It creates the src pointer first, which is then invalidated by a
unique borrow of the destination pointer. Swap the borrows around
to fix this. Found with miri.
    @Noratrieb
    Noratrieb committed Jun 4, 2022
    Configuration menu
    Copy the full SHA
    7e3bee6 View commit details
    Browse the repository at this point in the history