Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove feature: crate visibility modifier #97254

Merged
merged 2 commits into from
May 23, 2022
Merged

Remove feature: crate visibility modifier #97254

merged 2 commits into from
May 23, 2022

Conversation

jhpratt
Copy link
Member

@jhpratt jhpratt commented May 21, 2022

FCP completed in #53120.

@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label May 21, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in src/tools/rustfmt.

cc @rust-lang/rustfmt

Some changes occurred in src/tools/clippy.

cc @rust-lang/clippy

@rust-highfive
Copy link
Collaborator

r? @cjgillot

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 21, 2022
@jhpratt jhpratt mentioned this pull request May 21, 2022
Closed
4 tasks
@jhpratt jhpratt force-pushed the remove-crate-vis branch from 5259d02 to 06b95b9 Compare May 21, 2022 18:45
@jhpratt
Copy link
Member Author

jhpratt commented May 21, 2022

CI is green.

@jhpratt jhpratt force-pushed the remove-crate-vis branch from 06b95b9 to 7b987e3 Compare May 21, 2022 21:03
@cjgillot
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented May 22, 2022

📌 Commit 7b987e3 has been approved by cjgillot

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2022
@bors
Copy link
Contributor

bors commented May 22, 2022

⌛ Testing commit 7b987e3 with merge fce5cb75b281d232807fdb057b214d47a188e3eb...

@jackh726
Copy link
Member

@bors retry aarch64-gnu seems stuck

It's been running for over 2.5 hours when normally it takes <50 mins.

@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@Dylan-DPC Dylan-DPC mentioned this pull request May 23, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 23, 2022
@bors
Auto merge of rust-lang#97304 - Dylan-DPC:rollup-qxrfddc, r=Dylan-DPC
9e2f655 
Rollup of 5 pull requests

Successful merges:

 - rust-lang#97087 (Clarify slice and Vec iteration order)
 - rust-lang#97254 (Remove feature: `crate` visibility modifier)
 - rust-lang#97271 (Add regression test for rust-lang#91949)
 - rust-lang#97294 (std::time : fix variable name in the doc)
 - rust-lang#97303 (Fix some typos in arg checking algorithm)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit b73f1c7 into rust-lang:master May 23, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 23, 2022
@jhpratt jhpratt deleted the remove-crate-vis branch May 24, 2022 12:40
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 4, 2022
@Dylan-DPC
Rollup merge of rust-lang#97254 - jhpratt:remove-crate-vis, r=cjgillot
77d2b10 
Remove feature: `crate` visibility modifier

FCP completed in rust-lang#53120.
@mbartlett21
Copy link
Contributor

@jhpratt Just a note: The feature doesn't end up even saying it is removed if you have used the crate visibility modifier anywhere, since it doesn't parse any more.

For example, in a crate I had that used it, all it gave was this, and no other errors:

error: expected one of `!` or `::`, found keyword `struct`
  --> src\main.rs:68:11
   |
68 |     crate struct Features(u8);
   |           ^^^^^^ expected one of `!` or `::`

@jhpratt
Copy link
Member Author

jhpratt commented Jun 5, 2022

Eh, I don't see an issue with that to be honest. That's what happens when things are removed.

@apiraino apiraino mentioned this pull request Aug 3, 2022
Closed
@jplatte jplatte mentioned this pull request Jun 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

@fbstj fbstj fbstj left review comments

Assignees

@cjgillot cjgillot

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
10 participants
@jhpratt @rust-highfive @cjgillot @bors @jackh726 @rust-log-analyzer @mbartlett21 @fbstj @petrochenkov @rustbot