-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc_parse: Move AST -> TokenStream conversion logic to rustc_ast #97251
Conversation
Very nice: +130 -298 @bors r+ |
📌 Commit d0607449eac63ec1fcb400a77968bc399309e609 has been approved by |
@bors r=nnethercote |
📌 Commit 09b4c7c has been approved by |
☀️ Test successful - checks-actions |
Finished benchmarking commit (4bb4dc4): comparison url. Instruction count
Max RSS (memory usage)Results
CyclesResults
If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf. @rustbot label: -perf-regression Footnotes |
A small performance win too, nice. |
In the past falling back to reparsing pretty-printed strings was common, so some of this logic had to live in
rustc_parse
, but now the reparsing fallback is only used in two corner cases so we can move this logic torustc_ast
which makes many things simpler.It also helps to fix
MacArgs::inner_tokens
forMacArgs::Eq
with non-literal expressions, which is done in the second commit.r? @nnethercote