Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stage0 bootstrap bump #97147

Merged
merged 3 commits into from
May 20, 2022
Merged

stage0 bootstrap bump #97147

merged 3 commits into from
May 20, 2022

Conversation

Mark-Simulacrum
Copy link
Member

@rustbot rustbot added T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 18, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 18, 2022
@Mark-Simulacrum
Copy link
Member Author

Also included RLS bump -- forward-porting from the beta change.

@pietroalbini
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 18, 2022

📌 Commit bf29b3c has been approved by pietroalbini

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 18, 2022
@bors
Copy link
Contributor

bors commented May 19, 2022

⌛ Testing commit bf29b3c with merge 7c3b3e2b15cb8b0ddb990aa06e3490168ed96044...

@bors
Copy link
Contributor

bors commented May 19, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 7c3b3e2b15cb8b0ddb990aa06e3490168ed96044 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 19, 2022
@bors
Copy link
Contributor

bors commented May 19, 2022

👀 Test was successful, but fast-forwarding failed: 422 Update is not a fast forward

@Mark-Simulacrum
Copy link
Member Author

@bors retry

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (7c3b3e2b15cb8b0ddb990aa06e3490168ed96044): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: 🎉 relevant improvement found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 1 9 1
mean2 N/A N/A -1.5% -2.2% -1.5%
max N/A N/A -1.5% -3.9% -1.5%

Cycles

Results
  • Primary benchmarks: 😿 relevant regression found
  • Secondary benchmarks: no relevant changes found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 1 0 0 0 1
mean2 1.2% N/A N/A N/A 1.2%
max 1.2% N/A N/A N/A 1.2%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩ ↩2

  2. the arithmetic mean of the percent change ↩ ↩2

@bors
Copy link
Contributor

bors commented May 20, 2022

⌛ Testing commit bf29b3c with merge 52cc779...

@bors
Copy link
Contributor

bors commented May 20, 2022

☀️ Test successful - checks-actions
Approved by: pietroalbini
Pushing 52cc779 to master...

@bors bors merged commit 52cc779 into rust-lang:master May 20, 2022
@rustbot rustbot added this to the 1.63.0 milestone May 20, 2022
@rust-highfive
Copy link
Collaborator

📣 Toolstate changed by #97147!

Tested on commit 52cc779.
Direct link to PR: #97147

🎉 rls on windows: build-fail → test-pass (cc @Xanewok).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok).

rust-highfive added a commit to rust-lang-nursery/rust-toolstate that referenced this pull request May 20, 2022
@rust-highfive
📣 Toolstate changed by rust-lang/rust#97147!
ba015b9 
Tested on commit rust-lang/rust@52cc779.
Direct link to PR: <rust-lang/rust#97147>

🎉 rls on windows: build-fail → test-pass (cc @Xanewok).
🎉 rls on linux: build-fail → test-pass (cc @Xanewok).
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (52cc779): comparison url.

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results
  • Primary benchmarks: no relevant changes found
  • Secondary benchmarks: 🎉 relevant improvements found
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 0 0 0 3 0
mean2 N/A N/A N/A -2.1% N/A
max N/A N/A N/A -3.2% N/A

Cycles

Results
  • Primary benchmarks: mixed results
  • Secondary benchmarks: mixed results
Regressions 😿
(primary)		 Regressions 😿
(secondary)		 Improvements 🎉
(primary)		 Improvements 🎉
(secondary)		 All 😿 🎉
(primary)
count1 10 1 2 1 12
mean2 3.3% 5.2% -3.6% -1.8% 2.2%
max 5.2% 5.2% -4.4% -1.8% 5.2%

If you disagree with this performance assessment, please file an issue in rust-lang/rustc-perf.

@rustbot label: -perf-regression

Footnotes

  1. number of relevant changes ↩ ↩2

  2. the arithmetic mean of the percent change ↩ ↩2

@Urgau
Copy link
Member

Urgau commented May 20, 2022

When I run the stage0/cargo with this PR I'm seeing a version of 1.61.beta.7, is that expected ? I would have expected the beta 1.62.* something not 1.61.

$ ./build/x86_64-unknown-linux-gnu/stage0/bin/cargo -V
cargo 1.61.0-beta.7 (a028ae4 2022-04-29)

@Mark-Simulacrum Mark-Simulacrum deleted the stage0-bump branch May 20, 2022 12:33
@Mark-Simulacrum
Copy link
Member Author

Hm, it might be that I didn't wait long enough for the beta to be pushed up. We'll want another bump anyway to pick up beta built with released stable, so I'll open another PR if necessary. We might want to list the version number, not just date, in the stage0.json to make this easier to catch.

@Mark-Simulacrum Mark-Simulacrum mentioned this pull request May 20, 2022
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 29, 2022
@bors
Auto merge of rust-lang#97214 - Mark-Simulacrum:stage0-bump, r=pietro…
bef2b7c 
…albini

Finish bumping stage0

It looks like the last time had left some remaining cfg's -- which made me think
that the stage0 bump was actually successful. This brings us to a released 1.62
beta though.

This now brings us to cfg-clean, with the exception of check-cfg-features in bootstrap;
I'd prefer to leave that for a separate PR at this time since it's likely to be more tricky.

cc rust-lang#97147 (comment)

r? `@pietroalbini`
workingjubilee pushed a commit to tcdi/postgrestd that referenced this pull request Sep 15, 2022
@bors
Auto merge of #97214 - Mark-Simulacrum:stage0-bump, r=pietroalbini
f01b40c 
Finish bumping stage0

It looks like the last time had left some remaining cfg's -- which made me think
that the stage0 bump was actually successful. This brings us to a released 1.62
beta though.

This now brings us to cfg-clean, with the exception of check-cfg-features in bootstrap;
I'd prefer to leave that for a separate PR at this time since it's likely to be more tricky.

cc rust-lang/rust#97147 (comment)

r? `@pietroalbini`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.63.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Mark-Simulacrum @rust-highfive @pietroalbini @bors @rust-timer @Urgau @rustbot