Close out #9155 #9697
Merged
Close out #9155 #9697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a test to make sure it works and switch a private struct over to a newtype. Closes rust-lang#9155
|
Passed all tests, but GitHub went down. Merging manually in an attempt to get bors going again. |
thestinger
added a commit
that referenced
this pull request
Oct 3, 2013
flip1995
pushed a commit
to flip1995/rust
that referenced
this pull request
Nov 21, 2022
…p1995 Mark `let_underscore_lock` and `let_underscore_drop` as uplifted Here I've renamed both the uplifted lints, however rustc's `let_underscore_lock` is slightly less capable than the clippy lint as it doesn't catch `parking_lot` types or `Result<Guard, ..>`, should we still remove it? The `Result` change looks like it was unintentional to me so that could probably be fixed upstream changelog: Uplift [`let_underscore_drop`] to rustc rust-lang#97739 changelog: Remove overlap between rustc's `let_underscore_lock` and Clippy's [`let_underscore_lock`] r? `@flip1995`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test to make sure it works and switch a private struct over to a
newtype.
Closes #9155