Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change eslint rules from configuration comments to configuration file #96805

Merged
merged 1 commit into from
May 7, 2022

Conversation

Folyd
Copy link
Contributor

@Folyd Folyd commented May 7, 2022

Repeatedly declaring eslint rules in source files is an annoying thing, we should move those rules into the eslint configuration file.

r? @GuillaumeGomez

@rustbot rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label May 7, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 7, 2022
@@ -41,4 +41,4 @@ ENV SCRIPT python3 ../x.py --stage 2 test src/tools/expand-yaml-anchors && \
/scripts/validate-error-codes.sh && \
# Runs checks to ensure that there are no ES5 issues in our JS code.
es-check es6 ../src/librustdoc/html/static/js/*.js && \
eslint ../src/librustdoc/html/static/js/*.js
eslint -c ../src/librustdoc/html/static/.eslintrc.js ../src/librustdoc/html/static/js/*.js
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I no sure the change of this line is necessary, however, to make it explicit, I prefer to keep this change.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also prefer to keep this change.

@GuillaumeGomez
Copy link
Member

This is a very good idea, thanks!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 7, 2022

📌 Commit a8ede12 has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 7, 2022
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 7, 2022
Change eslint rules from configuration comments to configuration file

Repeatedly declaring eslint rules in source files is an annoying thing, we should move those rules into the eslint configuration file.

r? `@GuillaumeGomez`
bors added a commit to rust-lang-ci/rust that referenced this pull request May 7, 2022
…laumeGomez

Rollup of 7 pull requests

Successful merges:

 - rust-lang#96581 (make Size and Align debug-printing a bit more compact)
 - rust-lang#96636 (Fix jump to def regression)
 - rust-lang#96760 (diagnostics: port more diagnostics to derive + add support for `Vec` fields)
 - rust-lang#96788 (Improve validator around field projections and checked bin ops)
 - rust-lang#96805 (Change eslint rules from configuration comments to configuration file)
 - rust-lang#96807 (update Miri)
 - rust-lang#96811 (Fix a minor typo in the description of Formatter)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f98f92f into rust-lang:master May 7, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 7, 2022
@Folyd Folyd deleted the eslint branch May 7, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants