Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rotation animation on settings button when loading #96704

Merged
merged 1 commit into from
May 6, 2022

Conversation

GuillaumeGomez
Copy link
Member

As discussed, I added an animation when the settings JS file is loading (I voluntarily made the timeout at the end of the settings.js super long so we can see what the animation looks like):

Peek.2022-05-04.15-38.mp4

r? @jsha

@GuillaumeGomez GuillaumeGomez added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-rustdoc-ui Area: Rustdoc UI (generated HTML) A-rustdoc-js Area: Rustdoc's JS front-end labels May 4, 2022
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS/JS.

cc @GuillaumeGomez,@Folyd,@jsha

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 4, 2022
@bors
Copy link
Contributor

bors commented May 5, 2022

☔ The latest upstream changes (presumably #96720) made this pull request unmergeable. Please resolve the merge conflicts.

@GuillaumeGomez
Copy link
Member Author

Fixed merge conflict.

@jsha
Copy link
Contributor

jsha commented May 5, 2022

Can you put up a demo?

@GuillaumeGomez
Copy link
Member Author

Unless you block the JS to be downloaded, you won't be able to see the rotation. Do you want me to put up a demo in any case?

@jsha
Copy link
Contributor

jsha commented May 5, 2022

Yep - devtools can do various things to simulate slow or offline loading. There's also a very simple expedient to test such things - turn of your Wi-Fi. :-)

@GuillaumeGomez
Copy link
Member Author

Such ancient dark magic. A world where you can turn off the internet. This is too scary to even imagine it. 😨

(uploading the demo 😆 )

@GuillaumeGomez
Copy link
Member Author

The demo is now up here.

@jsha
Copy link
Contributor

jsha commented May 5, 2022

@bors r+ rollup

Nice!

@bors
Copy link
Contributor

bors commented May 5, 2022

📌 Commit 13b45aa has been approved by jsha

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2022
compiler-errors added a commit to compiler-errors/rust that referenced this pull request May 5, 2022
…r=jsha

Add rotation animation on settings button when loading

As discussed, I added an animation when the settings JS file is loading (I voluntarily made the timeout at the end of the `settings.js` super long so we can see what the animation looks like):

https://user-images.githubusercontent.com/3050060/166693243-816a08b7-5e39-4142-acd3-686ad9950d8e.mp4

r? ``@jsha``
compiler-errors added a commit to compiler-errors/rust that referenced this pull request May 6, 2022
…r=jsha

Add rotation animation on settings button when loading

As discussed, I added an animation when the settings JS file is loading (I voluntarily made the timeout at the end of the `settings.js` super long so we can see what the animation looks like):

https://user-images.githubusercontent.com/3050060/166693243-816a08b7-5e39-4142-acd3-686ad9950d8e.mp4

r? ```@jsha```
bors added a commit to rust-lang-ci/rust that referenced this pull request May 6, 2022
…piler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#96174 (mark ptr-int-transmute test as no_run)
 - rust-lang#96639 (Fix typo in `offset_from` documentation)
 - rust-lang#96704 (Add rotation animation on settings button when loading)
 - rust-lang#96730 (Add a regression test for rust-lang#64173 and rust-lang#66152)
 - rust-lang#96741 (Improve settings loading strategy)
 - rust-lang#96744 (Implement [OsStr]::join)
 - rust-lang#96747 (Add `track_caller` to `DefId::expect_local()`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 292eefe into rust-lang:master May 6, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 6, 2022
@GuillaumeGomez GuillaumeGomez deleted the rotation-animation branch May 6, 2022 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-rustdoc-js Area: Rustdoc's JS front-end A-rustdoc-ui Area: Rustdoc UI (generated HTML) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants