Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::fmt: Various fixes and improvements to documentation #96568

Merged
merged 5 commits into from
May 2, 2022

Conversation

EliasHolzmann
Copy link
Contributor

This PR contains the following changes:

  • Added argument index comments to examples for specifying precision

    The examples for specifying the precision have comments explaining which
    argument the specifier is referring to. However, for implicit positional
    arguments, the examples simply refer to "next arg". To simplify following the
    comments, "next arg" was supplemented with the actual resulting argument index.

  • Fixed documentation for specifying precision via .*

    The documentation stated that in case of the syntax {<arg>:<spec>.*}, "the
    <arg> part refers to the value to print, and the precision must come in the
    input preceding <arg>". This is not correct: the part does indeed refer
    to the value to print, but the precision does not come in the input preciding
    arg, but in the next implicit input (as if specified with {}).

    Fixes std::fmt: Precision via asterisk does not fit documentation when using named or explicit positional arguments #96413.

  • Fix the grammar documentation

    According to the grammar documented, the format specifier {: } should not be
    legal because of the whitespace it contains. However, in reality, this is
    perfectly fine because the actual implementation allows spaces before the
    closing brace. Fixes Format string parser does not fail on invalid input #71088.

    Also, the exact meaning of most of the terminal symbols was not specified, for
    example the meaning of identifier.

  • Removed reference to Formatter::buf and other private fields

    Formatter::buf is not a public field and therefore isn't very helpful in user-
    facing documentation. Also, the other public fields of Formatter were removed
    during stabilization of std::fmt (4af3494) and can only be accessed via
    getters.

  • Improved list of formatting macros

    Two improvements:

    1. write! can not only receive a io::Write, but also a fmt::Write as first argument.
    2. The description texts now contain links to the actual macros for easier
      navigation.

@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Apr 30, 2022
@rust-highfive
Copy link
Collaborator

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with r? rust-lang/libs-api @rustbot label +T-libs-api -T-libs to request review from a libs-api team reviewer. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @joshtriplett (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 30, 2022
@joshtriplett
Copy link
Member

Posted one minor nit; LGTM otherwise.

The documentation stated that in case of the syntax `{<arg>:<spec>.*}`, "the
`<arg>` part refers to the value to print, and the precision must come in the
input preceding `<arg>`". This is not correct: the <arg> part does indeed refer
to the value to print, but the precision does not come in the input preciding
arg, but in the next implicit input (as if specified with {}).

Fixes rust-lang#96413.
…ecision

The examples for specifying the precision have comments explaining which
argument the specifier is referring to. However, for implicit positional
arguments, the examples simply talk about "next arg". To make it easier for
readers to follow the comments, "next arg" was supplemented with the actual
resulting argument index.
According to the grammar documented, the format specifier `{: }` should not be
legal because of the whitespace it contains. However, in reality, this is
perfectly fine because the actual implementation allows spaces before the
closing brace. Fixes rust-lang#71088.

Also, the exact meaning of most of the terminal symbols was not specified, for
example the meaning of `identifier`.
Formatter::buf is not a public field and therefore isn't very helpful in user-
facing documentation. Also, the other public fields of Formatter were made
private during stabilization of std::fmt (4af3494) and can now only be read
via accessor methods.
Two improvements:
1. write! can not only receive a `io::Write`, but also a `fmt::Write` as first argument.
2. The description texts now contain links to the actual macros for easier
   navigation.
@joshtriplett
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 1, 2022

📌 Commit f3b86c3 has been approved by joshtriplett

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2022
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2022
Rollup of 7 pull requests

Successful merges:

 - rust-lang#94126 (Classify BinaryHeap & LinkedList unit tests as such)
 - rust-lang#96222 (Clarify docs for `from_raw_parts` on `Vec` and `String`)
 - rust-lang#96499 (Make it possible to write doctests for bootstrap)
 - rust-lang#96567 (Fix docs for u32 and i32 logs func)
 - rust-lang#96568 (std::fmt: Various fixes and improvements to documentation)
 - rust-lang#96571 (Add a bathroom stall to weird expressions test)
 - rust-lang#96610 (Update browser-ui-test version to 0.9.0)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ab1ae48 into rust-lang:master May 2, 2022
@rustbot rustbot added this to the 1.62.0 milestone May 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
5 participants