-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stabilize const_ptr_offset_from
.
#96240
Stabilize const_ptr_offset_from
.
#96240
Conversation
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
r? @m-ou-se (rust-highfive has picked a reviewer for you, use r? to override) |
r? rust-lang/libs-api @rustbot label +T-libs-api +T-lang -T-libs |
This comment has been minimized.
This comment has been minimized.
85a8c2c
to
acef376
Compare
☔ The latest upstream changes (presumably #95837) made this pull request unmergeable. Please resolve the merge conflicts. |
acef376
to
77f5bb4
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
a36e998
to
c182720
Compare
Is there an update for this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than bumping the version to 1.63, LGTM.
c182720
to
0030103
Compare
bumped. |
☔ The latest upstream changes (presumably #97214) made this pull request unmergeable. Please resolve the merge conflicts. |
(deleted) |
0030103
to
c886f1d
Compare
r? rust-lang/libs |
library/core/src/intrinsics.rs
Outdated
@@ -1903,11 +1903,11 @@ extern "rust-intrinsic" { | |||
pub fn nontemporal_store<T>(ptr: *mut T, val: T); | |||
|
|||
/// See documentation of `<*const T>::offset_from` for details. | |||
#[rustc_const_unstable(feature = "const_ptr_offset_from", issue = "92980")] | |||
#[rustc_const_stable(feature = "const_ptr_offset_from", since = "1.63.0")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1.64.0 here and lower?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
c886f1d
to
0f013f1
Compare
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Sorry to bump this again, but I think this stabilization is super exciting and important, since it finally allows for const |
I'm not on T-libs-api, but I'll take another look at it in the near future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As with before, diff LGTM. Just needs the version bumped to 1.65, naturally.
0f013f1
to
9c1bb80
Compare
This comment has been minimized.
This comment has been minimized.
Stabilization has been completed [here](rust-lang#92980 (comment)) with a FCP.
9c1bb80
to
69ad634
Compare
@bors r+ rollup |
…ffset_from, r=Mark-Simulacrum Stabilize `const_ptr_offset_from`. Stabilization has been completed [here](rust-lang#92980 (comment)) with a FCP. Closes rust-lang#92980.
Rollup of 11 pull requests Successful merges: - rust-lang#96240 (Stabilize `const_ptr_offset_from`.) - rust-lang#99784 (Make forward compatibility lint deprecated_cfg_attr_crate_type_name deny by default) - rust-lang#100811 (Fix wrong compiletest filters on Windows) - rust-lang#100924 (Smaller improvements of tidy and the unicode generator) - rust-lang#100953 (Update documentation for `write!` and `writeln!`) - rust-lang#101018 (rustdoc: omit start/end tags for empty item description blocks) - rust-lang#101044 (rustdoc: remove unused CSS for `hidden-by-*-hider`) - rust-lang#101046 (rustdoc: remove incorrect CSS selector `.impl-items table td`) - rust-lang#101057 (Merge implementations of HIR fn_decl and fn_sig.) - rust-lang#101062 (rustdoc: remove empty extern_crates and type="text/javascript" on script) - rust-lang#101063 (Merge duplicated CSS rules) Failed merges: - rust-lang#101055 (Use smaller span for suggestions) r? `@ghost` `@rustbot` modify labels: rollup
…et_from)]` The `const_ptr_offset_from` feature was stabilized by [rust-lang/rust#96240][1]. [1]: rust-lang/rust#96240
Stabilization has been completed here with a FCP.
Closes #92980.